Bug 163929 - URLParser should match old URL::parse with %2E in path
Summary: URLParser should match old URL::parse with %2E in path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-24 17:18 PDT by Alex Christensen
Modified: 2016-10-25 00:05 PDT (History)
1 user (show)

See Also:

Attachments
Patch (12.52 KB, patch)
2016-10-24 17:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (23.55 KB, patch)
2016-10-24 17:33 PDT, Alex Christensen 		ap: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (15.73 MB, application/zip)
2016-10-24 18:31 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-10-24 17:18:51 PDT 
URLParser should match old URL::parse with %2E in path
Comment 1 Alex Christensen 2016-10-24 17:20:11 PDT 
Created attachment 292683 [details]
Patch
Comment 2 Alex Christensen 2016-10-24 17:33:09 PDT 
Created attachment 292684 [details]
Patch
Comment 3 Alexey Proskuryakov 2016-10-24 17:55:16 PDT 
Comment on attachment 292684 [details]
Patch

R=me pending EWS.
Comment 4 Build Bot 2016-10-24 18:31:37 PDT 
Comment on attachment 292684 [details]
Patch

Attachment 292684 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2361837

New failing tests:
fetch/fetch-url-serialization.html
Comment 5 Build Bot 2016-10-24 18:31:40 PDT 
Created attachment 292695 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Alex Christensen 2016-10-24 18:34:44 PDT 
http://trac.webkit.org/changeset/207795
Comment 7 Alex Christensen 2016-10-24 18:35:01 PDT 
(note: also updated fetch/fetch-url-serialization-expected.txt)
Comment 8 Ryan Haddad 2016-10-24 19:12:24 PDT 
This change appears to have caused API test failures.

Tests that failed:
  URLParserTest.AdditionalTests
  WebKit1.LoadInvalidURLRequest
  WebKit2.LoadInvalidURLRequest

Tests that timed out:
  URLParserTest.DefaultPort
  URLParserTest.ParserDifferences

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/967
Comment 9 Ryan Haddad 2016-10-24 20:49:24 PDT 
Reverted r207795 for reason:

Introduced API test failures on iOS and macOS.

Committed r207803: <http://trac.webkit.org/changeset/207803>
Comment 10 Alex Christensen 2016-10-24 21:43:41 PDT 
http://trac.webkit.org/changeset/207805
I had accidentally committed a local change unconditionally enabling URLParser everywhere.
Comment 11 Alex Christensen 2016-10-25 00:05:25 PDT 
https://trac.webkit.org/r207811