Bug 163920 - [WebIDL] Move more types over to the new JSConverter based toJS functions
Summary: [WebIDL] Move more types over to the new JSConverter based toJS functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-24 16:23 PDT by Sam Weinig
Modified: 2016-10-25 11:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (51.51 KB, patch)
2016-10-24 16:37 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (51.60 KB, patch)
2016-10-24 17:00 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (18.92 MB, application/zip)
2016-10-24 18:25 PDT, Build Bot
no flags Details
Patch (52.42 KB, patch)
2016-10-24 21:33 PDT, Sam Weinig
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-10-24 16:23:20 PDT
[WebIDL] Move more types over to the new JSConverter based toJS functions
Comment 1 Sam Weinig 2016-10-24 16:37:01 PDT
Created attachment 292675 [details]
Patch
Comment 2 Sam Weinig 2016-10-24 17:00:25 PDT
Created attachment 292679 [details]
Patch
Comment 3 Build Bot 2016-10-24 18:24:58 PDT
Comment on attachment 292679 [details]
Patch

Attachment 292679 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2361739

New failing tests:
fast/forms/date/input-valueasdate-date.html
fast/forms/time/time-valueasdate.html
fast/forms/month/input-valueasdate.html
fast/forms/month/input-valueasdate-month.html
Comment 4 Build Bot 2016-10-24 18:25:02 PDT
Created attachment 292693 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 Sam Weinig 2016-10-24 21:33:52 PDT
Created attachment 292713 [details]
Patch
Comment 6 Darin Adler 2016-10-24 22:19:13 PDT
Comment on attachment 292713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292713&action=review

> Source/WebCore/bindings/js/JSDOMIterator.h:42
> +enum class JSDOMIteratorType {
> +    Set,
> +    Map
> +};

How about putting this on one line?

> Source/WebCore/bindings/js/JSDOMIterator.h:81
> +template<typename JSWrapper, typename IteratorTraits>
>  class JSDOMIterator: public JSDOMObject {

This too, how about putting it on one line? Also, space after JSDOMIterator before colon please.

> Source/WebCore/bindings/js/JSDOMIterator.h:131
> +    JSC::MarkedArgumentBuffer args;

Could use a whole word here, arguments.

> Source/WebCore/bindings/js/JSDOMIterator.h:172
> +    return JSC::JSValue();

Could write { } instead of JSC::JSValue().

> Source/WebCore/bindings/js/JSDOMIterator.h:193
> +    return JSC::JSValue();

Ditto.

> Source/WebCore/bindings/js/JSDOMIterator.h:216
> +template<typename JSIterator>
> +JSC::JSValue iteratorForEach(JSC::ExecState& state, typename JSIterator::Wrapper& thisObject, JSC::ThrowScope& scope)

Same idea of a single line, but not as sure since so many things above have to be split into multiple lines.
Comment 7 Sam Weinig 2016-10-25 11:37:52 PDT
Committed r207829: <http://trac.webkit.org/changeset/207829>