Bug 163906 - The URLSearchParams constructor should take a union in parameter
Summary: The URLSearchParams constructor should take a union in parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://url.spec.whatwg.org/#urlsearc...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-24 12:10 PDT by Chris Dumez
Modified: 2016-10-26 16:18 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.17 KB, patch)
2016-10-24 12:11 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (3.17 KB, patch)
2016-10-24 13:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-24 12:10:03 PDT
The URLSearchParams constructor should take a union in parameter:
- https://url.spec.whatwg.org/#urlsearchparams
Comment 1 Chris Dumez 2016-10-24 12:11:26 PDT
Created attachment 292640 [details]
Patch
Comment 2 Darin Adler 2016-10-24 12:36:47 PDT
Comment on attachment 292640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292640&action=review

> Source/WebCore/html/URLSearchParams.h:59
> +Ref<URLSearchParams> URLSearchParams::create(const StringOrURLSearchParams& variant, DOMURL* associatedURL)

If we put this in the header, it has to be marked inline.
Comment 3 Chris Dumez 2016-10-24 13:23:45 PDT
Created attachment 292647 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-26 16:18:42 PDT
Comment on attachment 292647 [details]
Patch

Clearing flags on attachment: 292647

Committed r207914: <http://trac.webkit.org/changeset/207914>
Comment 5 WebKit Commit Bot 2016-10-26 16:18:48 PDT
All reviewed patches have been landed.  Closing bug.