Bug 163896 - Dumping of op_negate bytecode is broken.
Summary: Dumping of op_negate bytecode is broken.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-24 10:15 PDT by Mark Lam
Modified: 2016-10-24 10:56 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch. (1.23 KB, patch)
2016-10-24 10:18 PDT, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-10-24 10:15:31 PDT
It's thinks the bytecode consists of only 3 machine words, when it consists of 4.
Comment 1 Mark Lam 2016-10-24 10:16:11 PDT
(In reply to comment #0)
> It's thinks the bytecode consists of only 3 machine words, when it consists
> of 4.

/It's/It/
Comment 2 Mark Lam 2016-10-24 10:18:44 PDT
Created attachment 292621 [details]
proposed patch.
Comment 3 Darin Adler 2016-10-24 10:21:53 PDT
Comment on attachment 292621 [details]
proposed patch.

Do we have regression tests for this sort of thing?
Comment 4 Mark Lam 2016-10-24 10:23:53 PDT
(In reply to comment #3)
> Comment on attachment 292621 [details]
> proposed patch.
> 
> Do we have regression tests for this sort of thing?

Not that I know of.  The dumper is a debugging tool, and it fails instantaneously on use right at the site of use.  So, it should be easy to debug and fix.
Comment 5 WebKit Commit Bot 2016-10-24 10:56:29 PDT
Comment on attachment 292621 [details]
proposed patch.

Clearing flags on attachment: 292621

Committed r207765: <http://trac.webkit.org/changeset/207765>
Comment 6 WebKit Commit Bot 2016-10-24 10:56:34 PDT
All reviewed patches have been landed.  Closing bug.