Bug 163895 - More PassRefPtr purging in WebCore.
Summary: More PassRefPtr purging in WebCore.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2016-10-24 09:46 PDT by Andreas Kling
Modified: 2016-10-25 03:30 PDT (History)
1 user (show)

See Also:

Patch (59.92 KB, patch)
2016-10-24 09:47 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-10-24 09:46:19 PDT
Did a bit of Sunday night PassRefPtr removal. Patch coming.
Comment 1 Andreas Kling 2016-10-24 09:47:07 PDT
Created attachment 292618 [details]
Comment 2 WebKit Commit Bot 2016-10-24 09:49:28 PDT
Attachment 292618 [details] did not pass style-queue:

ERROR: Source/WebCore/rendering/RenderLayer.h:216:  'createScrollbar' is incorrectly named. It should be named 'protector' or 'protectedScrollbarOrientation'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/rendering/style/RenderStyle.h:1532:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 2 in 50 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2016-10-25 02:54:46 PDT
Comment on attachment 292618 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=292618&action=review

> Source/WebCore/rendering/RenderThemeGtk.cpp:73
>      static RenderTheme& rt = RenderThemeGtk::create().leakRef();
> -    return &rt;
> +    return rt;

You could also give it a real name.

> Source/WebCore/rendering/RenderThemeMac.mm:203
>      static RenderTheme& rt = RenderThemeMac::create().leakRef();
> -    return &rt;
> +    return rt;

Here too.
Comment 4 WebKit Commit Bot 2016-10-25 03:30:02 PDT
Comment on attachment 292618 [details]

Clearing flags on attachment: 292618

Committed r207814: <http://trac.webkit.org/changeset/207814>
Comment 5 WebKit Commit Bot 2016-10-25 03:30:05 PDT
All reviewed patches have been landed.  Closing bug.