Bug 163895 – More PassRefPtr purging in WebCore.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Andreas Kling]

Did a bit of Sunday night PassRefPtr removal. Patch coming.

[Andreas Kling]

Created attachment 292618 [details]
Patch

[WebKit Commit Bot]

Attachment 292618 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderLayer.h:216:  'createScrollbar' is incorrectly named. It should be named 'protector' or 'protectedScrollbarOrientation'.  [readability/naming/protected] [4]
ERROR: Source/WebCore/rendering/style/RenderStyle.h:1532:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 2 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 292618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292618&action=review

> Source/WebCore/rendering/RenderThemeGtk.cpp:73
>      static RenderTheme& rt = RenderThemeGtk::create().leakRef();
> -    return &rt;
> +    return rt;

You could also give it a real name.

> Source/WebCore/rendering/RenderThemeMac.mm:203
>      static RenderTheme& rt = RenderThemeMac::create().leakRef();
> -    return &rt;
> +    return rt;

Here too.

[WebKit Commit Bot]

Comment on attachment 292618 [details]
Patch

Clearing flags on attachment: 292618

Committed r207814: <http://trac.webkit.org/changeset/207814>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.