Bug 16389 - Common Implementation of NetscapePlugInStreamLoader
Summary: Common Implementation of NetscapePlugInStreamLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-10 14:50 PST by Rodney Dawes
Modified: 2007-12-16 17:50 PST (History)
0 users

See Also:


Attachments
Common impl of NetscapePlugInStreamLoader (3.16 KB, patch)
2007-12-10 14:51 PST, Rodney Dawes
mrowe: review-
Details | Formatted Diff | Diff
Updated patch to remove win32 specific portions (7.95 KB, patch)
2007-12-12 13:29 PST, Rodney Dawes
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodney Dawes 2007-12-10 14:50:48 PST
The code in NetscapePlugInStreamLoaderWin.cpp is not specific to win32, and is usable on other platforms as well. We should use this code as the default implementation, rather than having no implementation for the default. This patch adds this code to the common loader/NetscapePlugInStreamLoader.cpp as the common default implementation.
Comment 1 Rodney Dawes 2007-12-10 14:51:22 PST
Created attachment 17829 [details]
Common impl of NetscapePlugInStreamLoader
Comment 2 Mark Rowe (bdash) 2007-12-10 20:18:52 PST
Comment on attachment 17829 [details]
Common impl of NetscapePlugInStreamLoader

My reading of this suggests that we'd now have two identical implementations of NetscapePlugInStreamLoader in the tree.  This code should be shared rather than duplicated.
Comment 3 Rodney Dawes 2007-12-11 08:10:41 PST
(In reply to comment #2)
> (From update of attachment 17829 [details] [edit])
> My reading of this suggests that we'd now have two identical implementations of
> NetscapePlugInStreamLoader in the tree.  This code should be shared rather than
> duplicated.
> 

This would be that shared code. I don't know how to remove the file from the win32 builds, as a different build system is used there. I could remove the win32 port file from svn with this patch, but then it would just break the build. The appropriate build files need to be updated as well. Should I just resubmit with the file removal in the patch also?
Comment 4 Rodney Dawes 2007-12-12 13:29:16 PST
Created attachment 17868 [details]
Updated patch to remove win32 specific portions

This updated patch also removes the NetscapePlugInLoaderWin.cpp file and it's reference in the WebCore.vcproj.
Comment 5 Maciej Stachowiak 2007-12-14 15:52:59 PST
Comment on attachment 17868 [details]
Updated patch to remove win32 specific portions

r=me
Comment 6 Mark Rowe (bdash) 2007-12-16 17:50:57 PST
Landed in r28790.