Bug 163889 - [CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file
Summary: [CodeGenerator] Only allow a single interface or standalone dictionary per We...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-24 07:28 PDT by Zan Dobersek
Modified: 2016-10-24 11:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.99 KB, patch)
2016-10-24 07:41 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (48.66 KB, patch)
2016-10-24 07:53 PDT, Zan Dobersek
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2016-10-24 07:28:02 PDT
[CodeGenerator] Only allow a single interface or standalone dictionary per WebIDL file
Comment 1 Zan Dobersek 2016-10-24 07:41:24 PDT
Created attachment 292609 [details]
Patch
Comment 2 Zan Dobersek 2016-10-24 07:44:32 PDT
Comment on attachment 292609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292609&action=review

> Source/WebCore/ChangeLog:29
> +        * bindings/scripts/test/attribute.idl: Copied from Source/WebCore/bindings/scripts/test/TestException.idl.
> +        * bindings/scripts/test/readonly.idl: Copied from Source/WebCore/bindings/scripts/test/TestException.idl.

These two could probably be merged into one test case.
Comment 3 Zan Dobersek 2016-10-24 07:53:57 PDT
Created attachment 292610 [details]
Patch
Comment 4 Chris Dumez 2016-10-24 09:37:27 PDT
Comment on attachment 292610 [details]
Patch

Makes sense, r=me
Comment 5 Zan Dobersek 2016-10-24 11:32:26 PDT
Committed r207770: <http://trac.webkit.org/changeset/207770>