Move operations should be sufficient
Created attachment 292607 [details] Patch
Comment on attachment 292607 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292607&action=review > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:629 > + m_mediaEndpoint->setConfiguration({ WTFMove(iceServers), configuration.iceTransportPolicy(), configuration.bundlePolicy() }); You may need to add a IceServerInfo constructor because some of the linux bots still use GCC 4.9 (if it fails, it won't be caught by the EWS bots). See the comments in bug163255 and bug162147.
(In reply to comment #2) > Comment on attachment 292607 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=292607&action=review > > > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:629 > > + m_mediaEndpoint->setConfiguration({ WTFMove(iceServers), configuration.iceTransportPolicy(), configuration.bundlePolicy() }); > > You may need to add a IceServerInfo constructor because some of the linux > bots still use GCC 4.9 (if it fails, it won't be caught by the EWS bots). > See the comments in bug163255 and bug162147. Thanks for the pointer, I will update the patch accordingly at landing time or in a future version. I was waiting for the GTK bot before marking patch as r? but it seems gtk bot has some issues.
Created attachment 292741 [details] Patch
Created attachment 292745 [details] Patch
Comment on attachment 292745 [details] Patch Clearing flags on attachment: 292745 Committed r207818: <http://trac.webkit.org/changeset/207818>
All reviewed patches have been landed. Closing bug.