Bug 163880 - [CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it
Summary: [CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it
Status: RESOLVED DUPLICATE of bug 163885
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-24 01:26 PDT by Zan Dobersek
Modified: 2016-10-24 03:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2016-10-24 01:32 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2016-10-24 01:26:52 PDT 
[CodeGeneratorJS] Enum generation uses NeverDestroyed<>, doesn't include it
Comment 1 Zan Dobersek 2016-10-24 01:32:45 PDT 
Created attachment 292595 [details]
Patch
Comment 2 youenn fablet 2016-10-24 02:21:48 PDT 
Comment on attachment 292595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292595&action=review

> Source/WebCore/ChangeLog:16
> +        specified in the same file.

Can we add a binding test to cover this then?
Comment 3 Zan Dobersek 2016-10-24 02:33:15 PDT 
Comment on attachment 292595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292595&action=review

>> Source/WebCore/ChangeLog:16
>> +        specified in the same file.
> 
> Can we add a binding test to cover this then?

The problem is that standalone dictionaries don't generate enumeration conversion code ATM. But I have a patch to fix that, so this AddToImplIncludes() call can be patched there.
Comment 4 Zan Dobersek 2016-10-24 03:18:07 PDT 

*** This bug has been marked as a duplicate of bug 163885 ***