Bug 163876 – Move all classes in the HTML directory from ExceptionCode to Exception

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Darin Adler]

Move all classes in the HTML directory from ExceptionCode to Exception

[Darin Adler]

Created attachment 292558 [details]
Patch

[WebKit Commit Bot]

Attachment 292558 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:309:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 149 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 292560 [details]
Patch

[WebKit Commit Bot]

Attachment 292560 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:309:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 152 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 292625 [details]
Patch

[WebKit Commit Bot]

Attachment 292625 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:303:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 156 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 292625 [details]
Patch

Attachment 292625 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2359646

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 292636 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292625 [details]
Patch

Attachment 292625 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2359663

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 292637 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292625 [details]
Patch

Attachment 292625 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2359642

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 292638 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Darin Adler]

Created attachment 292712 [details]
Patch

[WebKit Commit Bot]

Attachment 292712 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:303:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 168 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 292717 [details]
Patch

[WebKit Commit Bot]

Attachment 292717 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:303:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 170 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 292719 [details]
Patch

[WebKit Commit Bot]

Attachment 292719 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:303:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 170 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 292721 [details]
Patch

[WebKit Commit Bot]

Attachment 292721 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:303:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 171 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 292724 [details]
Patch

[WebKit Commit Bot]

Attachment 292724 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:303:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 171 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 292724 [details]
Patch

Attachment 292724 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2363369

New failing tests:
dom/html/level2/html/HTMLTableRowElement18.html
dom/html/level2/html/HTMLTableSectionElement28.html
dom/xhtml/level2/html/HTMLTableRowElement18.xhtml
media/track/add-and-remove-track.html
media/range-extract-contents-crash.html
dom/xhtml/level2/html/HTMLTableSectionElement27.xhtml
dom/xhtml/level2/html/HTMLTableSectionElement29.xhtml
dom/html/level2/html/HTMLTableRowElement19.html
imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html
dom/html/level2/html/HTMLTableSectionElement29.html
dom/xhtml/level2/html/HTMLTableSectionElement28.xhtml
dom/xhtml/level2/html/HTMLTableRowElement19.xhtml
imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html
dom/xhtml/level2/html/HTMLTableRowElement17.xhtml
dom/html/level2/html/HTMLTableRowElement17.html
dom/html/level2/html/HTMLTableSectionElement27.html

[Build Bot]

Created attachment 292728 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292724 [details]
Patch

Attachment 292724 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2363372

New failing tests:
dom/html/level2/html/HTMLTableRowElement18.html
dom/xhtml/level2/html/HTMLTableSectionElement29.xhtml
dom/html/level2/html/HTMLTableSectionElement28.html
dom/xhtml/level2/html/HTMLTableRowElement18.xhtml
media/track/add-and-remove-track.html
media/range-extract-contents-crash.html
dom/xhtml/level2/html/HTMLTableSectionElement27.xhtml
imported/w3c/web-platform-tests/url/url-setters.html
dom/html/level2/html/HTMLTableRowElement19.html
imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html
dom/html/level2/html/HTMLTableSectionElement29.html
dom/xhtml/level2/html/HTMLTableSectionElement28.xhtml
imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html
dom/xhtml/level2/html/HTMLTableRowElement19.xhtml
dom/xhtml/level2/html/HTMLTableRowElement17.xhtml
dom/html/level2/html/HTMLTableRowElement17.html
dom/html/level2/html/HTMLTableSectionElement27.html

[Build Bot]

Created attachment 292729 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292724 [details]
Patch

Attachment 292724 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2363413

New failing tests:
dom/html/level2/html/HTMLTableRowElement18.html
dom/xhtml/level2/html/HTMLTableRowElement17.xhtml
dom/xhtml/level2/html/HTMLTableSectionElement28.xhtml
dom/xhtml/level2/html/HTMLTableRowElement18.xhtml
media/track/add-and-remove-track.html
media/range-extract-contents-crash.html
dom/xhtml/level2/html/HTMLTableSectionElement27.xhtml
dom/xhtml/level2/html/HTMLTableSectionElement29.xhtml
imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tbody-element/deleteRow.html
dom/html/level2/html/HTMLTableSectionElement29.html
dom/html/level2/html/HTMLTableSectionElement28.html
imported/w3c/web-platform-tests/html/semantics/tabular-data/the-tr-element/deleteCell.html
dom/xhtml/level2/html/HTMLTableRowElement19.xhtml
dom/html/level2/html/HTMLTableRowElement19.html
dom/html/level2/html/HTMLTableRowElement17.html
dom/html/level2/html/HTMLTableSectionElement27.html

[Build Bot]

Created attachment 292731 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Darin Adler]

Created attachment 292990 [details]
Patch

[WebKit Commit Bot]

Attachment 292990 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:287:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMTokenList.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLElement.cpp"
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 181 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Created attachment 292993 [details]
Patch

[WebKit Commit Bot]

Attachment 292993 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:287:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMTokenList.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLElement.cpp"
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 183 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 292993 [details]
Patch

Attachment 292993 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2383485

New failing tests:
imported/w3c/web-platform-tests/url/url-setters.html

[Build Bot]

Created attachment 292997 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292993 [details]
Patch

Attachment 292993 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2384368

New failing tests:
imported/w3c/web-platform-tests/url/url-setters.html

[Build Bot]

Created attachment 293002 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Darin Adler]

Created attachment 293026 [details]
Patch

[WebKit Commit Bot]

Attachment 293026 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:287:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMTokenList.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLElement.cpp"
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 182 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 293026 [details]
Patch

Attachment 293026 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2387014

New failing tests:
imported/w3c/web-platform-tests/url/url-setters.html

[Build Bot]

Created attachment 293032 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293026 [details]
Patch

Attachment 293026 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2387039

New failing tests:
imported/w3c/web-platform-tests/url/url-setters.html

[Build Bot]

Created attachment 293035 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Darin Adler]

Created attachment 293106 [details]
Patch

[WebKit Commit Bot]

Attachment 293106 [details] did not pass style-queue:


WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableSectionElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLSelectElement.cpp"
ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:287:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableRowElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMTokenList.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLElement.cpp"
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 186 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 293106 [details]
Patch

Attachment 293106 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2390195

New failing tests:
imported/w3c/web-platform-tests/url/url-setters.html

[Build Bot]

Created attachment 293115 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 293106 [details]
Patch

Attachment 293106 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2390238

New failing tests:
imported/w3c/web-platform-tests/url/url-setters.html

[Build Bot]

Created attachment 293116 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Darin Adler]

Patch is ready to go now, ready for review. The only failures we are seeing on the EWS servers now are the strange URL setters test failure. I will look into that later this morning.

[Darin Adler]

I see what’s going on now. I "accidentally" fixed some problems with our implementation of the DOM URL object, and the changes in those test results reflect the progressions. I will included updated expected results in a revised patch.

[Darin Adler]

Created attachment 293178 [details]
Patch

[WebKit Commit Bot]

Attachment 293178 [details] did not pass style-queue:


WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableSectionElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLSelectElement.cpp"
ERROR: Source/WebCore/html/MediaController.h:127:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:287:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableRowElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMTokenList.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp"
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLElement.cpp"
ERROR: Source/WebCore/html/ImageData.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/html/ImageData.cpp:91:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 4 in 188 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

OK, ready for review now.

[Sam Weinig]

Comment on attachment 293178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293178&action=review

> Source/WebCore/ChangeLog:5797
> +        * platform/graphics/win/ImageBufferDirect2D.cpp:
> +        (WebCore::ImageBuffer::toDataURL):
> +        * platform/image-encoders/JPEGImageEncoder.cpp:
> +        (WebCore::compressRGBABigEndianToJPEG):
> +        * platform/image-encoders/JPEGImageEncoder.h:
> +        * platform/mac/WebVideoFullscreenHUDWindowController.mm:
> +        (-[WebVideoFullscreenHUDWindowController setVolume:]):
> +        * xml/parser/XMLDocumentParserLibxml2.cpp:
> +        (WebCore::XMLDocumentParser::endElementNs):
> +
> +        * rendering/RenderThemeGtk.cpp:
> +        (WebCore::RenderThemeGtk::paintMediaSliderTrack): Updated for changes to
> +        the TimeRanges class.

I don't think this is in the right place.

> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:107
>      auto type = convert<IDLNullable<IDLDOMString>>(state, state.argument(0));

I think you need a RETURN_IF_EXCEPTION here.

> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:112
> +        quality = qualityValue.toNumber(&state);

Same here.

> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:120
> +    // We don't use the cached version of jsString here, because these are likely to be differing long strings.
> +    return jsString(&state, result.releaseReturnValue());

I guess we need some flags to pass the toJS<> guys as well.

> Source/WebCore/html/HTMLEmbedElement.idl:33
> +    [CheckSecurityForNode, MayThrowException] SVGDocument getSVGDocument();

There is no such type as a SVGDocument as far as the bindings are concerned. This should just be Document.

> Source/WebCore/html/HTMLFrameElement.idl:37
> +    [CheckSecurityForNode, MayThrowException] SVGDocument getSVGDocument();

There is no such type as a SVGDocument as far as the bindings are concerned. This should just be Document.

[Chris Dumez]

Comment on attachment 293178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293178&action=review

> Source/WebCore/html/HTMLTextAreaElement.cpp:208
> +    internalSetMaxLength(parseHTMLNonNegativeInteger(newValue).valueOr(-1));

How does this work? parseHTMLNonNegativeInteger() returns an Optional<unsigned> so I would think Optional<unsigned>::valueOr() would return an unsigned. However, you're giving -1. Doesn't this cast -1 to unsigned?

[Chris Dumez]

Sorry, did not mean to revert Sam's r+, just got a conflict upon submitting.

[Darin Adler]

Comment on attachment 293178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293178&action=review

>> Source/WebCore/html/HTMLEmbedElement.idl:33
>> +    [CheckSecurityForNode, MayThrowException] SVGDocument getSVGDocument();
> 
> There is no such type as a SVGDocument as far as the bindings are concerned. This should just be Document.

Hoops that's just a merging mistake. I originally did this change before the SVG document change.

>> Source/WebCore/html/HTMLFrameElement.idl:37
>> +    [CheckSecurityForNode, MayThrowException] SVGDocument getSVGDocument();
> 
> There is no such type as a SVGDocument as far as the bindings are concerned. This should just be Document.

Will fix this one too.

>> Source/WebCore/html/HTMLTextAreaElement.cpp:208
>> +    internalSetMaxLength(parseHTMLNonNegativeInteger(newValue).valueOr(-1));
> 
> How does this work? parseHTMLNonNegativeInteger() returns an Optional<unsigned> so I would think Optional<unsigned>::valueOr() would return an unsigned. However, you're giving -1. Doesn't this cast -1 to unsigned?

Here's how it works: passing -1 to the valueOr function causes it to be converted to unsigned. Then returning the result of the function converts it back from unsigned two int. The -1 value survives both conversions. If you think that's too ugly I can try to come up with a different way to do this. It's particularly awkward that the function to parse has to return either unsigned or int when we know it returns a value that will fit in either!

[Darin Adler]

Comment on attachment 293178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293178&action=review

>> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:107
>>      auto type = convert<IDLNullable<IDLDOMString>>(state, state.argument(0));
> 
> I think you need a RETURN_IF_EXCEPTION here.

OK, added. The old code didn’t have it, but hey, I am happy to fix that.

>> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:112
>> +        quality = qualityValue.toNumber(&state);
> 
> Same here.

No, don’t need it here. We are calling toNumber only if isNumber is true, so no chance of an exception.

>> Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp:120
>> +    return jsString(&state, result.releaseReturnValue());
> 
> I guess we need some flags to pass the toJS<> guys as well.

Good point.

I added that comment because the old code was calling JSC::jsString and at first I could not figure out why.

I wonder what it would take to make this entire function be autogenerated.

[Darin Adler]

https://trac.webkit.org/changeset/208096

[Simon Fraser (smfr)]

This seems to have broken fast/custom-elements/reactions/HTMLOptionsCollection.html https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r208096%20(1128)/results.html

[Darin Adler]

OK, I’ll take a look. For some reason it did not break that when running tests on EWS earlier.

[Darin Adler]

Should be fixed by https://trac.webkit.org/changeset/208098

Not sure why that other test failed, though.

[Chris Dumez]

(In reply to comment #61)
> OK, I’ll take a look. For some reason it did not break that when running
> tests on EWS earlier.

I believe Ryosuke landed a new CEReactions patch today. Could be a conflict between the 2 patches.

[Darin Adler]

(In reply to comment #63)
> (In reply to comment #61)
> > OK, I’ll take a look. For some reason it did not break that when running
> > tests on EWS earlier.
> 
> I believe Ryosuke landed a new CEReactions patch today. Could be a conflict
> between the 2 patches.

Yes, I figured out that one and I believe I fixed it already.

But it also seems that, in that run Simon linked to, media/modern-media-controls/volume-support/volume-support-drag.html is failing and I don’t know why. I am rebuilding so I can see if I can reproduce that locally.

[Darin Adler]

Or maybe that one is just flaky.

[Chris Dumez]

(In reply to comment #65)
> Or maybe that one is just flaky.

It is not failing in the following build :
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r208097%20(1129)/results.html

So likely a flake indeed.

[Chris Dumez]

FYI, this patch was apparently a 0.75% speedometer regression on iOS.

[Chris Dumez]

(In reply to comment #67)
> FYI, this patch was apparently a 0.75% speedometer regression on iOS.

Filed <rdar://problem/29290316>.