Bug 163875 - Avoid unnecessary full style resolution in getComputedStyle for non-inherited properties
Summary: Avoid unnecessary full style resolution in getComputedStyle for non-inherited...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-23 13:10 PDT by Antti Koivisto
Modified: 2016-10-24 02:54 PDT (History)
2 users (show)

See Also:

Attachments
patch (10.05 KB, patch)
2016-10-23 14:55 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.27 MB, application/zip)
2016-10-23 15:56 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (9.40 MB, application/zip)
2016-10-23 16:08 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.91 MB, application/zip)
2016-10-23 23:21 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-yosemite (1.19 MB, application/zip)
2016-10-23 23:25 PDT, Build Bot 		no flags Details
patch (10.75 KB, patch)
2016-10-24 02:15 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-10-23 13:10:37 PDT 
Optimize.
Comment 1 Antti Koivisto 2016-10-23 14:55:42 PDT 
Created attachment 292556 [details]
patch
Comment 2 Darin Adler 2016-10-23 15:35:19 PDT 
Comment on attachment 292556 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292556&action=review

> Source/WebCore/css/StyleResolver.cpp:1820
> +        // Color is an inherited property so depending on it effecively makes the property inherited.

The word effectively is misspelled here.
Comment 3 Build Bot 2016-10-23 15:56:13 PDT 
Comment on attachment 292556 [details]
patch

Attachment 292556 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2353063

New failing tests:
css3/parse-alignment-of-root-elements.html
Comment 4 Build Bot 2016-10-23 15:56:15 PDT 
Created attachment 292559 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-10-23 16:08:38 PDT 
Comment on attachment 292556 [details]
patch

Attachment 292556 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2353086

New failing tests:
css3/parse-alignment-of-root-elements.html
Comment 6 Build Bot 2016-10-23 16:08:41 PDT 
Created attachment 292562 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2016-10-23 23:21:54 PDT 
Comment on attachment 292556 [details]
patch

Attachment 292556 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2355741

New failing tests:
css3/parse-alignment-of-root-elements.html
Comment 8 Build Bot 2016-10-23 23:21:57 PDT 
Created attachment 292584 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-10-23 23:25:25 PDT 
Comment on attachment 292556 [details]
patch

Attachment 292556 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2355832

New failing tests:
css3/parse-alignment-of-root-elements.html
Comment 10 Build Bot 2016-10-23 23:25:28 PDT 
Created attachment 292585 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Antti Koivisto 2016-10-24 02:15:32 PDT 
Created attachment 292598 [details]
patch
Comment 12 Antti Koivisto 2016-10-24 02:54:04 PDT 
https://trac.webkit.org/r207755