Bug 163870 - [CSS Parser] Unprefix -webkit-writing-mode
Summary: [CSS Parser] Unprefix -webkit-writing-mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-23 09:20 PDT by Dave Hyatt
Modified: 2016-10-24 12:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.60 KB, patch)
2016-10-23 09:22 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (5.54 KB, patch)
2016-10-23 09:24 PDT, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (41.73 KB, patch)
2016-10-23 15:01 PDT, Dave Hyatt 		zalan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (9.47 MB, application/zip)
2016-10-23 16:20 PDT, Build Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-10-23 09:20:45 PDT 
The SVG fill and stroke properties are no longer stored as SVGPaint CSSValues in the back end parser, so the apply code needs to handle it.
Comment 1 Dave Hyatt 2016-10-23 09:22:17 PDT 
Created attachment 292547 [details]
Patch
Comment 2 Dave Hyatt 2016-10-23 09:24:01 PDT 
Created attachment 292548 [details]
Patch
Comment 3 zalan 2016-10-23 09:37:53 PDT 
Changelog entry?
Comment 4 Dave Hyatt 2016-10-23 15:01:09 PDT 
Created attachment 292557 [details]
Patch
Comment 5 Build Bot 2016-10-23 16:20:45 PDT 
Comment on attachment 292557 [details]
Patch

Attachment 292557 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2353122

New failing tests:
svg/text/text-align-06-b.svg
svg/text/text-vkern.svg
svg/batik/text/verticalText.svg
svg/W3C-SVG-1.1/text-align-06-b.svg
svg/batik/text/verticalTextOnPath.svg
Comment 6 Build Bot 2016-10-23 16:20:49 PDT 
Created attachment 292563 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 7 Dave Hyatt 2016-10-24 07:43:01 PDT 
Landed in r207756. Other platforms may need to rebaseline some things. I have no idea why the ios-sim is failing. It's acting like it didn't even apply the patch.
Comment 8 Dave Hyatt 2016-10-24 07:43:57 PDT 
I meant r207757.
Comment 9 Ryan Haddad 2016-10-24 12:14:42 PDT 
This change caused the ios-simulator failures mentioned above (https://bugs.webkit.org/show_bug.cgi?id=163904), as well as flaky failures / assertion failures on mac with http/tests/misc/acid2.html and http/tests/misc/acid2-pixel.html (https://bugs.webkit.org/show_bug.cgi?id=163905)