Bug 163863 - addEventListener() / removeEventListener() should use a union for last parameter
Summary: addEventListener() / removeEventListener() should use a union for last parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-22 20:26 PDT by Chris Dumez
Modified: 2016-10-23 15:58 PDT (History)
8 users (show)

See Also:


Attachments
Patch (11.61 KB, patch)
2016-10-22 20:34 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-22 20:26:09 PDT
addEventListener() / removeEventListener() should use a union for last parameter:
- https://dom.spec.whatwg.org/#eventtarget
Comment 1 Chris Dumez 2016-10-22 20:34:50 PDT
Created attachment 292531 [details]
Patch
Comment 2 Chris Dumez 2016-10-23 11:06:22 PDT
Comment on attachment 292531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292531&action=review

> Source/WebCore/bindings/js/JSDOMConvert.h:643
> +            return std::move<WTF::CheckMoveParameter>(ConditionalConverter<ReturnType, IDLBoolean, hasBooleanType>::convert(state, value).value());

Also fixes Boolean support in unions.
Comment 3 WebKit Commit Bot 2016-10-23 15:58:32 PDT
Comment on attachment 292531 [details]
Patch

Clearing flags on attachment: 292531

Committed r207734: <http://trac.webkit.org/changeset/207734>
Comment 4 WebKit Commit Bot 2016-10-23 15:58:37 PDT
All reviewed patches have been landed.  Closing bug.