RESOLVED FIXED 163863
addEventListener() / removeEventListener() should use a union for last parameter 
https://bugs.webkit.org/show_bug.cgi?id=163863
Summary addEventListener() / removeEventListener() should use a union for last parameter
Chris Dumez
Reported 2016-10-22 20:26:09 PDT
addEventListener() / removeEventListener() should use a union for last parameter: - https://dom.spec.whatwg.org/#eventtarget
Attachments
Patch (11.61 KB, patch)
2016-10-22 20:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-22 20:34:50 PDT
Created attachment 292531 [details] Patch
Chris Dumez
Comment 2 2016-10-23 11:06:22 PDT
Comment on attachment 292531 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292531&action=review > Source/WebCore/bindings/js/JSDOMConvert.h:643 > + return std::move<WTF::CheckMoveParameter>(ConditionalConverter<ReturnType, IDLBoolean, hasBooleanType>::convert(state, value).value()); Also fixes Boolean support in unions.
WebKit Commit Bot
Comment 3 2016-10-23 15:58:32 PDT
Comment on attachment 292531 [details] Patch Clearing flags on attachment: 292531 Committed r207734: <http://trac.webkit.org/changeset/207734>
WebKit Commit Bot
Comment 4 2016-10-23 15:58:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.