Bug 163855 - [MediaStream] Separate media capture and audio playback muting
Summary: [MediaStream] Separate media capture and audio playback muting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-22 14:35 PDT by Eric Carlson
Modified: 2016-10-24 10:56 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch. (23.59 KB, patch)
2016-10-23 21:45 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Proposed patch. (24.26 KB, patch)
2016-10-24 09:06 PDT, Eric Carlson 		darin: review+
Details | Formatted Diff | Diff
Patch for landing. (25.36 KB, patch)
2016-10-24 10:12 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Updated patch for landing. (25.41 KB, patch)
2016-10-24 10:18 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-10-22 14:35:34 PDT 
The host application should be able to mute media capture and audio playback independently.
Comment 1 Eric Carlson 2016-10-22 14:36:03 PDT 
<rdar://problem/28827186>
Comment 2 Eric Carlson 2016-10-23 21:45:00 PDT 
Created attachment 292579 [details]
Proposed patch.
Comment 3 Eric Carlson 2016-10-24 09:06:32 PDT 
Created attachment 292616 [details]
Proposed patch.
Comment 4 Darin Adler 2016-10-24 10:00:13 PDT 
Comment on attachment 292616 [details]
Proposed patch.

I think an isAudioMuted helper function would help keep this code easy to read.

Is the new failure of fast/mediastream/MediaStreamTrack-stop.html due to the patch?
Comment 5 Eric Carlson 2016-10-24 10:12:34 PDT 
Created attachment 292619 [details]
Patch for landing.
Comment 6 Eric Carlson 2016-10-24 10:18:19 PDT 
Created attachment 292620 [details]
Updated patch for landing.
Comment 7 Eric Carlson 2016-10-24 10:19:29 PDT 
(In reply to comment #4)
> Comment on attachment 292616 [details]
> Proposed patch.
> 
> I think an isAudioMuted helper function would help keep this code easy to
> read.
> 
Agreed, fixed.

> Is the new failure of fast/mediastream/MediaStreamTrack-stop.html due to the
> patch?
Yes, fixed.
Comment 8 Eric Carlson 2016-10-24 10:56:39 PDT 
Committed r207764: https://trac.webkit.org/r207764