Most of the content of kjs_window can be move to more appropriate places (to DOMWindow, WindowFeatures, etc.)
*** Bug 16386 has been marked as a duplicate of this bug. ***
Created attachment 17826 [details] First round of cleanup
Comment on attachment 17826 [details] First round of cleanup Please run the sort-Xcode-project-file script on the project file. + // - dialogHide: trusted && WindowFeatures::boolFeature(features, "dialoghide"), makes dialog hide when you print + // - help: WindowFeatures::boolFeature(features, "help", true), makes help icon appear in dialog (what does it do on Windows?) + // - unadorned: trusted && WindowFeatures::boolFeature(features, "unadorned"); Seems a little strange here. Global replace problem? +static bool isSeparator(::UChar c) I don't think you need the :: here. It was needed because of "using namespace KJS". + {} We usually put those braces on separate lines. Where's the update to the .pro and .bkl files? Otherwise looks fine.
Created attachment 17937 [details] move PausedTimeouts
The first patch was landed in r28592.
Comment on attachment 17937 [details] move PausedTimeouts r=me
Second patch landed in r28779.
Created attachment 17943 [details] move ScheduledAction
Comment on attachment 17943 [details] move ScheduledAction Please try to use separate bugs for separate patches. Otherwise the state of the bug gets confusing. r=me
Third patch landed in r28794. Closing this bug, but will follow up with other bugs for more specific single tasks.