Bug 163843 - Improve MiniBrowser window titles for URLs without paths and with no title
Summary: Improve MiniBrowser window titles for URLs without paths and with no title
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-22 00:12 PDT by mitz
Modified: 2016-10-22 09:33 PDT (History)
2 users (show)

See Also:


Attachments
Use the full URL if all else fails (3.52 KB, patch)
2016-10-22 00:23 PDT, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-10-22 00:12:41 PDT
If the URL doesn’t have a path and the webpage doesn’t have a title, WebKit2 windows show “(null)” in the title, and WebKit1 windows raise an exception, trying to set the NSWindow’s title to nil.
Comment 1 mitz 2016-10-22 00:23:35 PDT
Created attachment 292481 [details]
Use the full URL if all else fails
Comment 2 mitz 2016-10-22 09:33:14 PDT
Committed <https://trac.webkit.org/r207713>.