Bug 163837 - Move SVG from ExceptionCode to Exception
Summary: Move SVG from ExceptionCode to Exception
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-21 21:40 PDT by Darin Adler
Modified: 2016-10-22 13:59 PDT (History)
8 users (show)

See Also:


Attachments
Patch (195.84 KB, patch)
2016-10-21 22:31 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.05 MB, application/zip)
2016-10-21 23:33 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.28 MB, application/zip)
2016-10-21 23:37 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (9.47 MB, application/zip)
2016-10-21 23:48 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (1.82 MB, application/zip)
2016-10-22 00:00 PDT, Build Bot
no flags Details
Patch (198.49 KB, patch)
2016-10-22 09:37 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-10-21 21:40:33 PDT
Move SVG from ExceptionCode to Exception
Comment 1 Darin Adler 2016-10-21 22:31:27 PDT
Created attachment 292463 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-21 22:32:52 PDT
Attachment 292463 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGAnimationElement.h:160:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 80 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2016-10-21 23:33:43 PDT
Comment on attachment 292463 [details]
Patch

Attachment 292463 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2342993

New failing tests:
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/animations/svgangle-animation-rad-to-grad.html
svg/custom/sheet-title.svg
svg/dom/SVGAngle.html
svg/dom/valueAsString-null.html
svg/dom/SVGLength-px-with-context.html
svg/animations/svgangle-animation-deg-to-grad.html
svg/dom/SVGPreserveAspectRatio.html
svg/dom/SVGLength-px.html
Comment 4 Build Bot 2016-10-21 23:33:46 PDT
Created attachment 292476 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-10-21 23:37:43 PDT
Comment on attachment 292463 [details]
Patch

Attachment 292463 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2343000

New failing tests:
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/animations/svgangle-animation-rad-to-grad.html
svg/custom/sheet-title.svg
svg/dom/SVGAngle.html
svg/dom/valueAsString-null.html
svg/dom/SVGLength-px-with-context.html
svg/animations/svgangle-animation-deg-to-grad.html
svg/dom/SVGPreserveAspectRatio.html
svg/dom/SVGLength-px.html
Comment 6 Build Bot 2016-10-21 23:37:47 PDT
Created attachment 292477 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-10-21 23:48:18 PDT
Comment on attachment 292463 [details]
Patch

Attachment 292463 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2343004

New failing tests:
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/custom/sheet-title.svg
svg/dom/SVGAngle.html
svg/dom/valueAsString-null.html
svg/dom/SVGLength-px-with-context.html
svg/dom/SVGPreserveAspectRatio.html
svg/dom/SVGLength-px.html
Comment 8 Build Bot 2016-10-21 23:48:22 PDT
Created attachment 292478 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2016-10-22 00:00:28 PDT
Comment on attachment 292463 [details]
Patch

Attachment 292463 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2343028

New failing tests:
svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
svg/animations/svgangle-animation-rad-to-grad.html
svg/custom/sheet-title.svg
svg/dom/SVGAngle.html
svg/dom/valueAsString-null.html
svg/dom/SVGLength-px-with-context.html
svg/animations/svgangle-animation-deg-to-grad.html
svg/dom/SVGPreserveAspectRatio.html
svg/dom/SVGLength-px.html
Comment 10 Build Bot 2016-10-22 00:00:31 PDT
Created attachment 292479 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Darin Adler 2016-10-22 09:37:42 PDT
Created attachment 292499 [details]
Patch
Comment 12 WebKit Commit Bot 2016-10-22 09:40:48 PDT
Attachment 292499 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGAnimationElement.h:160:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 81 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 13 Darin Adler 2016-10-22 12:54:55 PDT
Everything passing on EWS. Ready for review.
Comment 14 Chris Dumez 2016-10-22 13:25:44 PDT
Comment on attachment 292499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292499&action=review

r=me

> Source/WebCore/svg/SVGGlyphRefElement.idl:23
> +    [Reflect=glyphRef] attribute DOMString glyphRef;

Wouldn't [Reflect] work?
Comment 15 Darin Adler 2016-10-22 13:34:51 PDT
(In reply to comment #14)
> > Source/WebCore/svg/SVGGlyphRefElement.idl:23
> > +    [Reflect=glyphRef] attribute DOMString glyphRef;
> 
> Wouldn't [Reflect] work?

Nope. [Reflect] will try to reflect with an attribute named "glyphref", all lowercase. But the SVG attribute is named "glyphRef" with a capital R. The actual attribute string still has a lowercase R but it won’t compile unless I specify it like this. Might be worth returning later to fix this small mess.
Comment 16 WebKit Commit Bot 2016-10-22 13:59:35 PDT
Comment on attachment 292499 [details]
Patch

Clearing flags on attachment: 292499

Committed r207716: <http://trac.webkit.org/changeset/207716>
Comment 17 WebKit Commit Bot 2016-10-22 13:59:41 PDT
All reviewed patches have been landed.  Closing bug.