Bug 163821 - WebPageProxy should not need PageActivityState
Summary: WebPageProxy should not need PageActivityState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-21 17:12 PDT by Gavin Barraclough
Modified: 2016-10-21 23:10 PDT (History)
0 users

See Also:

Attachments
Fix (13.64 KB, patch)
2016-10-21 17:18 PDT, Gavin Barraclough 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2016-10-21 17:12:20 PDT 
The PageActivityState is currently plumbed back from WebCore up to the UI process, to determine whether to enabled process suppression. However the information it contains (whether a page load is ongoing, whether audio is playing) is already available via other means. Remove this use of PageActivityState.
Comment 1 Gavin Barraclough 2016-10-21 17:18:50 PDT 
Created attachment 292436 [details]
Fix
Comment 2 Geoffrey Garen 2016-10-21 17:27:16 PDT 
Comment on attachment 292436 [details]
Fix

r=me

It scares me a little how distributed this stuff is throughout the codebase.
Comment 3 Gavin Barraclough 2016-10-21 23:10:17 PDT 
Committed revision 207706.