Bug 163802 - Slow and big Heap methods should not be inline
Summary: Slow and big Heap methods should not be inline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 163562
  Show dependency treegraph
 
Reported: 2016-10-21 10:40 PDT by Filip Pizlo
Modified: 2016-10-22 12:37 PDT (History)
5 users (show)

See Also:


Attachments
the patch (10.12 KB, patch)
2016-10-21 10:42 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (11.42 KB, patch)
2016-10-21 10:47 PDT, Filip Pizlo
keith_miller: review+
Details | Formatted Diff | Diff
patch for landing (12.05 KB, patch)
2016-10-21 13:40 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-10-21 10:40:18 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2016-10-21 10:42:02 PDT
Created attachment 292372 [details]
the patch
Comment 2 Filip Pizlo 2016-10-21 10:47:09 PDT
Created attachment 292374 [details]
the patch
Comment 3 Filip Pizlo 2016-10-21 10:48:23 PDT
Comment on attachment 292374 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292374&action=review

> Source/JavaScriptCore/heap/HeapInlines.h:-155
> -inline void Heap::reportExtraMemoryAllocated(size_t size)
> -{
> -    if (size > minExtraMemory) 
> -        reportExtraMemoryAllocatedSlowCase(size);
> -}
> -

Hmmm, maybe I shouldn't have made this inline.  I'll run benchmarks and find out. :-)
Comment 4 Keith Miller 2016-10-21 10:48:51 PDT
Comment on attachment 292374 [details]
the patch

r=me.
Comment 5 Filip Pizlo 2016-10-21 13:40:16 PDT
Created attachment 292391 [details]
patch for landing
Comment 6 Filip Pizlo 2016-10-22 12:37:53 PDT
Landed in https://trac.webkit.org/changeset/207714