Bug 163794 - [CSS Parser] Add support for -webkit-line-box-contain
Summary: [CSS Parser] Add support for -webkit-line-box-contain
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
Depends on:
Reported: 2016-10-21 09:57 PDT by Dave Hyatt
Modified: 2016-10-21 10:06 PDT (History)
1 user (show)

See Also:

Patch (3.70 KB, patch)
2016-10-21 09:58 PDT, Dave Hyatt
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-10-21 09:57:12 PDT
Add support for -webkit-line-box-contain.
Comment 1 Dave Hyatt 2016-10-21 09:58:10 PDT
Created attachment 292359 [details]
Comment 2 WebKit Commit Bot 2016-10-21 09:59:09 PDT
Attachment 292359 [details] did not pass style-queue:

ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 zalan 2016-10-21 10:00:21 PDT
Comment on attachment 292359 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=292359&action=review

> Source/WebCore/css/parser/CSSPropertyParser.cpp:3049
> +static RefPtr<CSSValue> consumeLineBoxContain(CSSParserTokenRange& range)

const range?
Comment 4 Dave Hyatt 2016-10-21 10:06:05 PDT
Fix landed in r207679.