SVG should not paint selection within a mask
Created attachment 292308 [details] Patch
Comment on attachment 292308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292308&action=review > Source/WebCore/rendering/PaintPhase.h:66 > + PaintBehaviorDoNotPaintSelection = 1 << 8, I would call this PaintBehaviorSkipSelection and put it after PaintBehaviorSelectionOnly, adjusting the bit shifts accordingly. I think PaintBehaviorSelectionOnly could use a rename too, since it doesn't mean "paint the selection", it means "paint the selected content". Either that or rename yours to "PaintBehaviorSkipSelectionHighlight". > Source/WebCore/rendering/svg/SVGInlineTextBox.cpp:266 > - if (hasSelection) { > + if (hasSelection && shouldPaintSelection) { If you introduce this flag, you need to make to work for all painting, not just SVG text painting.
Created attachment 292379 [details] Patch
Comment on attachment 292379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=292379&action=review > Source/WebCore/rendering/PaintPhase.h:66 > + PaintBehaviorSkipSelectionHighlight = 1 << 1, > + PaintBehaviorForceBlackText = 1 << 2, > + PaintBehaviorForceWhiteText = 1 << 3, > + PaintBehaviorFlattenCompositingLayers = 1 << 4, > + PaintBehaviorRenderingSVGMask = 1 << 5, > + PaintBehaviorSkipRootBackground = 1 << 6, > + PaintBehaviorRootBackgroundOnly = 1 << 7, > + PaintBehaviorSelectionAndBackgroundsOnly = 1 << 8, I've taken to lining up the = 1 << ... to make it easier to edit them, and to spot errors.
Committed r207692: <http://trac.webkit.org/changeset/207692>