Bug 163766 – bmalloc api should crash on failure to allocate when !isBmallocEnabled.

• Status: RESOLVED
• Resolution: FIXED
• Component: bmalloc

[Mark Lam]

Patch coming.

[Mark Lam]

Created attachment 292285 [details]
proposed patch.

[Keith Miller]

Comment on attachment 292285 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=292285&action=review

r=me with comments

> Source/bmalloc/bmalloc/Allocator.cpp:107
> +        auto result = realloc(object, newSize);

nit: auto seems a little unnecessary here

> Source/bmalloc/bmalloc/Allocator.cpp:197
> +        auto result = malloc(size);

nit: ditto

[Filip Pizlo]

Comment on attachment 292285 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=292285&action=review

R=me.  I'm assuming that there's a reason why we need to crash.

> Source/bmalloc/ChangeLog:3
> +        bmalloc api should crash on failure to allocate when GuardMalloc is used.

I recommend changing the title or adding a clarification that the crash-on-failure is for the !isBmallocEnabled case, which is broader than the GuardMalloc case.

[Mark Lam]

Thanks for the review.  I've changed the autos to void *s.  I've also changed the title, and added a comment in the ChangeLog to explain why crashing in bmalloc is what we want when we fail to allocate.

Landed in r207646: <http://trac.webkit.org/r207646>.