Bug 163761 - [JSC] Drop isEnvironmentRecord type info flag and use JSType information instead
Summary: [JSC] Drop isEnvironmentRecord type info flag and use JSType information instead
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-20 15:19 PDT by Yusuke Suzuki
Modified: 2016-10-20 18:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (20.55 KB, patch)
2016-10-20 17:53 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-10-20 15:19:08 PDT 
JSType already has information: WithScope, GlobalObject, ModuleLexicalEnvironment etc.
Instead of using a type info flag bit, just use these type info.
Comment 1 Yusuke Suzuki 2016-10-20 17:53:08 PDT 
Created attachment 292297 [details]
Patch
Comment 2 Keith Miller 2016-10-20 18:02:44 PDT 
Comment on attachment 292297 [details]
Patch

r=me. Nice, we can always use more bits!
Comment 3 Yusuke Suzuki 2016-10-20 18:06:45 PDT 
Comment on attachment 292297 [details]
Patch

Thanks :D
Comment 4 WebKit Commit Bot 2016-10-20 18:35:59 PDT 
Comment on attachment 292297 [details]
Patch

Clearing flags on attachment: 292297

Committed r207652: <http://trac.webkit.org/changeset/207652>
Comment 5 WebKit Commit Bot 2016-10-20 18:36:04 PDT 
All reviewed patches have been landed.  Closing bug.