Bug 163757 - Use IntSize::unclampedArea() in PDFDocumentImage::updateCachedImageIfNeeded()
Summary: Use IntSize::unclampedArea() in PDFDocumentImage::updateCachedImageIfNeeded()
Alias: None
Product: WebKit
Classification: Unclassified
Component: PDF (show other bugs)
Version: Safari 10
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Reported: 2016-10-20 13:40 PDT by David Kilzer (:ddkilzer)
Modified: 2016-10-21 09:16 PDT (History)
5 users (show)

See Also:

Patch v1 (2.45 KB, patch)
2016-10-20 13:41 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2016-10-20 13:40:14 PDT
Use IntSize::unclampedArea() in PDFDocumentImage::updateCachedImageIfNeeded().

Broken out from the original patch posted to Bug 163696.

Noticed while looking for places where "width * height *4" was computed.
Comment 1 David Kilzer (:ddkilzer) 2016-10-20 13:41:38 PDT
Created attachment 292245 [details]
Patch v1
Comment 2 Brent Fulgham 2016-10-21 09:12:44 PDT
Comment on attachment 292245 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=292245&action=review

Nice! r=me.

> Source/WebCore/ChangeLog:13
> +        previously.  Also gets rid of more safeCast<size_t>() use.

Comment 3 WebKit Commit Bot 2016-10-21 09:16:52 PDT
Comment on attachment 292245 [details]
Patch v1

Clearing flags on attachment: 292245

Committed r207676: <http://trac.webkit.org/changeset/207676>
Comment 4 WebKit Commit Bot 2016-10-21 09:16:56 PDT
All reviewed patches have been landed.  Closing bug.