Bug 163749 – IndexedDB 2.0: Support IDBObjectStore name assignment

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

IndexedDB 2.0: Support IDBObjectStore name assignment

[Brady Eidson]

<rdar://problem/28806931>

[Brady Eidson]

Created attachment 292238 [details]
Patch

[Alex Christensen]

Comment on attachment 292238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292238&action=review

test renaming an object store to an existing object store's name.

> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:115
> +        return Exception { INVALID_STATE_ERR, makeString(ASCIILiteral("Failed set property 'name' on 'IDBObjectStore': The database already has an object store named '"), name, ASCIILiteral("'.")) };

I'm not sure if ASCIILiteral helps if it's inside a makeString.

> LayoutTests/storage/indexeddb/resources/readonly.js:-33
> -    setReadonlyProperty("objectStore.name", "'bar'");

Explain why this is removed in the changelog.

[Build Bot]

Comment on attachment 292238 [details]
Patch

Attachment 292238 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2332893

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html
imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html

[Build Bot]

Created attachment 292243 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292238 [details]
Patch

Attachment 292238 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2332947

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html
imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html

[Build Bot]

Created attachment 292247 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292238 [details]
Patch

Attachment 292238 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2333027

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html
imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html

[Build Bot]

Created attachment 292253 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 292238 [details]
Patch

Attachment 292238 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2332982

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-errors.html
imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-rename-store.html

[Build Bot]

Created attachment 292257 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Brady Eidson]

Created attachment 292264 [details]
Patch

[Brady Eidson]

Relying on EWS to sort out layouttest issues, will cq+ once green.

[Brady Eidson]

The current ios-sim failure is unrelated stuff. cq+'ing

[WebKit Commit Bot]

Comment on attachment 292264 [details]
Patch

Clearing flags on attachment: 292264

Committed r207641: <http://trac.webkit.org/changeset/207641>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.