Bug 163747 - Many WebGL functions which don't throw are marked as possibly throwing
Summary: Many WebGL functions which don't throw are marked as possibly throwing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-20 12:09 PDT by Myles C. Maxfield
Modified: 2016-10-20 18:56 PDT (History)
7 users (show)

See Also:

Attachments
Patch (79.28 KB, patch)
2016-10-20 12:09 PDT, Myles C. Maxfield 		dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (79.30 KB, patch)
2016-10-20 13:55 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch for committing (79.31 KB, patch)
2016-10-20 16:18 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-10-20 12:09:11 PDT 
Many WebGL functions which don't throw are marked as possibly throwing
Comment 1 Myles C. Maxfield 2016-10-20 12:09:44 PDT 
Created attachment 292235 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-20 13:01:56 PDT 
The commit-queue encountered the following flaky tests while processing attachment 292235 [details]:

compositing/iframes/page-cache-layer-tree.html bug 163754 (authors: joepeck@webkit.org, rniwa@webkit.org, and simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2016-10-20 13:02:16 PDT 
Comment on attachment 292235 [details]
Patch

Rejecting attachment 292235 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 292235, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
eff94d147dca4bd625c1c6942375821a8b1
r207631 = b3a30c1cbe706dab34de75060cd4276f5776f3fb
r207632 = 82407bc8a514f65288e255174797bdd77abef16c
r207633 = 306a5ea1ea0285ac81d2352a9c655d968eea57ed
r207634 = 563b9b84eb222d852cae9d2a699821050aa6c081
r207635 = 87b66b0c37271fe01e794614314072171c46f9ab
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/2332887
Comment 4 Myles C. Maxfield 2016-10-20 13:55:35 PDT 
Created attachment 292251 [details]
Patch for committing
Comment 5 WebKit Commit Bot 2016-10-20 13:56:53 PDT 
Comment on attachment 292251 [details]
Patch for committing

Rejecting attachment 292251 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 292251, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/2333219
Comment 6 Myles C. Maxfield 2016-10-20 16:18:52 PDT 
Created attachment 292276 [details]
Patch for committing
Comment 7 WebKit Commit Bot 2016-10-20 16:54:11 PDT 
Comment on attachment 292276 [details]
Patch for committing

Clearing flags on attachment: 292276

Committed r207644: <http://trac.webkit.org/changeset/207644>