Bug 163740 - Invalid assertion in arguments elimination
Summary: Invalid assertion in arguments elimination
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-20 10:00 PDT by Keith Miller
Modified: 2016-10-20 10:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.15 KB, patch)
2016-10-20 10:08 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (3.22 KB, patch)
2016-10-20 10:09 PDT, Keith Miller 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-10-20 10:00:01 PDT 
Invalid assertion in arguments elimination
Comment 1 Keith Miller 2016-10-20 10:08:11 PDT 
Created attachment 292216 [details]
Patch
Comment 2 Keith Miller 2016-10-20 10:09:35 PDT 
Created attachment 292217 [details]
Patch
Comment 3 Keith Miller 2016-10-20 10:11:27 PDT 
<rdar://problem/27911462>
Comment 4 Michael Saboff 2016-10-20 10:31:45 PDT 
Comment on attachment 292217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292217&action=review

r=me

> Source/JavaScriptCore/ChangeLog:12
> +        number of reasons that a DFG GetFromArguments may not point to another a

Should "another" be removed?
Comment 5 Keith Miller 2016-10-20 10:33:41 PDT 
Comment on attachment 292217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292217&action=review

Thanks for the review.

>> Source/JavaScriptCore/ChangeLog:12
>> +        number of reasons that a DFG GetFromArguments may not point to another a
> 
> Should "another" be removed?

Fixed.
Comment 6 Keith Miller 2016-10-20 10:43:06 PDT 
Committed r207623: <http://trac.webkit.org/changeset/207623>
Comment 7 Filip Pizlo 2016-10-20 10:44:58 PDT 
Comment on attachment 292217 [details]
Patch

r=me too