Bug 163738 - The tracking of the coarse-grain Heap state (allocating or not, collector or not, eden vs full) should respect the orthogonality between allocating and collecting
Summary: The tracking of the coarse-grain Heap state (allocating or not, collector or ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 163562
  Show dependency tree / graph
 
Reported: 2016-10-20 09:56 PDT by Filip Pizlo
Modified: 2016-10-20 19:23 PDT (History)
0 users

See Also:

Attachments
it begins (52.92 KB, patch)
2016-10-20 09:57 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more (63.64 KB, patch)
2016-10-20 10:07 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
maybe it's done (73.49 KB, patch)
2016-10-20 11:25 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
more (81.26 KB, patch)
2016-10-20 11:44 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
getting closer (93.29 KB, patch)
2016-10-20 13:17 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (103.76 KB, patch)
2016-10-20 15:00 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (104.28 KB, patch)
2016-10-20 15:08 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
possible patch for landing (105.71 KB, patch)
2016-10-20 15:42 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
possible patch for landing (106.06 KB, patch)
2016-10-20 15:49 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
possible patch for landing (106.16 KB, patch)
2016-10-20 16:20 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-10-20 09:56:38 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-10-20 09:57:22 PDT 
Created attachment 292213 [details]
it begins
Comment 2 Filip Pizlo 2016-10-20 10:07:33 PDT 
Created attachment 292215 [details]
more
Comment 3 Filip Pizlo 2016-10-20 11:25:36 PDT 
Created attachment 292227 [details]
maybe it's done
Comment 4 Filip Pizlo 2016-10-20 11:44:03 PDT 
Created attachment 292232 [details]
more

More things are happy.
Comment 5 Filip Pizlo 2016-10-20 13:17:22 PDT 
Created attachment 292242 [details]
getting closer
Comment 6 Filip Pizlo 2016-10-20 15:00:18 PDT 
Created attachment 292265 [details]
the patch
Comment 7 Filip Pizlo 2016-10-20 15:08:41 PDT 
Created attachment 292266 [details]
the patch
Comment 8 Filip Pizlo 2016-10-20 15:34:16 PDT 
I'm fixing the WebCore build errors.
Comment 9 Geoffrey Garen 2016-10-20 15:39:05 PDT 
Comment on attachment 292266 [details]
the patch

r=me when it builds
Comment 10 Filip Pizlo 2016-10-20 15:42:43 PDT 
Created attachment 292272 [details]
possible patch for landing

Fixing WebCore things.
Comment 11 Filip Pizlo 2016-10-20 15:49:37 PDT 
Created attachment 292275 [details]
possible patch for landing
Comment 12 Filip Pizlo 2016-10-20 16:20:01 PDT 
Created attachment 292277 [details]
possible patch for landing

I think it might build now.
Comment 13 Filip Pizlo 2016-10-20 17:01:33 PDT 
I'll run JetStream and then land.
Comment 14 Filip Pizlo 2016-10-20 19:18:05 PDT 
(In reply to comment #13)
> I'll run JetStream and then land.

It's neutral (0.3% slower with 54% confidence).
Comment 15 Filip Pizlo 2016-10-20 19:23:43 PDT 
Landed in https://trac.webkit.org/changeset/207653