Bug 163730 - [Modern Media Controls] Media Controller: PiP support
Summary: [Modern Media Controls] Media Controller: PiP support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Safari 10
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-20 07:53 PDT by Antoine Quint
Modified: 2016-11-02 01:01 PDT (History)
5 users (show)

See Also:

Attachments
Patch (26.29 KB, patch)
2016-10-20 07:56 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.18 MB, application/zip)
2016-10-20 09:03 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.86 MB, application/zip)
2016-10-20 09:11 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (2.03 MB, application/zip)
2016-10-20 09:29 PDT, Build Bot 		no flags Details
Patch (61.91 KB, patch)
2016-10-31 07:19 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (deleted)
2016-10-31 08:28 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews103 for mac-yosemite (1.21 MB, application/zip)
2016-10-31 08:37 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (2.45 MB, application/zip)
2016-10-31 09:29 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (2.51 MB, application/zip)
2016-10-31 11:04 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (2.15 MB, application/zip)
2016-10-31 11:30 PDT, Build Bot 		no flags Details
Patch (61.95 KB, patch)
2016-10-31 14:56 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (64.27 KB, patch)
2016-10-31 15:23 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.24 MB, application/zip)
2016-10-31 16:32 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews102 for mac-yosemite (1.13 MB, application/zip)
2016-10-31 16:33 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (deleted)
2016-10-31 18:00 PDT, Build Bot 		no flags Details
Patch (64.78 KB, patch)
2016-11-01 02:59 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (69.66 KB, patch)
2016-11-01 03:20 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (69.66 KB, patch)
2016-11-01 03:21 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (15.56 KB, patch)
2016-11-01 11:59 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.00 MB, application/zip)
2016-11-01 12:38 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.12 MB, application/zip)
2016-11-01 13:04 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.72 MB, application/zip)
2016-11-01 13:11 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted)
2016-11-01 13:16 PDT, Build Bot 		no flags Details
Patch (17.01 KB, patch)
2016-11-01 14:07 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (17.03 KB, patch)
2016-11-01 14:14 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (17.29 KB, patch)
2016-11-01 23:42 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (17.29 KB, patch)
2016-11-02 00:24 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (26) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-10-20 07:53:40 PDT 
We need to only show the PiP button when PiP is supported and enter PiP when it's pressed.
Comment 1 Antoine Quint 2016-10-20 07:53:51 PDT 
<rdar://problem/27989485>
Comment 2 Antoine Quint 2016-10-20 07:56:23 PDT 
Created attachment 292189 [details]
Patch
Comment 3 Antoine Quint 2016-10-20 07:58:55 PDT 
Tests aren't ready yet but the source can be reviewed already.
Comment 4 Build Bot 2016-10-20 09:03:52 PDT 
Comment on attachment 292189 [details]
Patch

Attachment 292189 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2331584

New failing tests:
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/media-controller/media-controller-resize.html
media/modern-media-controls/start-support/start-support-error.html
media/modern-media-controls/mute-support/mute-support-media-api.html
media/modern-media-controls/media-controller/media-controller-constructor.html
media/modern-media-controls/start-support/start-support-no-source.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/mute-support/mute-support-button-click.html
media/modern-media-controls/start-support/start-support-autoplay.html
media/modern-media-controls/mute-support/mute-support-muted.html
Comment 5 Build Bot 2016-10-20 09:03:55 PDT 
Created attachment 292202 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-10-20 09:10:59 PDT 
Comment on attachment 292189 [details]
Patch

Attachment 292189 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2331538

New failing tests:
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/media-controller/media-controller-resize.html
media/modern-media-controls/start-support/start-support-error.html
media/modern-media-controls/start-support/start-support-no-source.html
media/modern-media-controls/media-controller/media-controller-constructor.html
media/modern-media-controls/mute-support/mute-support-media-api.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/mute-support/mute-support-button-click.html
media/modern-media-controls/start-support/start-support-autoplay.html
media/modern-media-controls/mute-support/mute-support-muted.html
Comment 7 Build Bot 2016-10-20 09:11:01 PDT 
Created attachment 292203 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-10-20 09:29:22 PDT 
Comment on attachment 292189 [details]
Patch

Attachment 292189 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2331659

New failing tests:
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/media-controller/media-controller-resize.html
media/modern-media-controls/start-support/start-support-error.html
media/modern-media-controls/mute-support/mute-support-media-api.html
media/modern-media-controls/media-controller/media-controller-constructor.html
media/modern-media-controls/start-support/start-support-no-source.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/mute-support/mute-support-button-click.html
media/modern-media-controls/start-support/start-support-autoplay.html
media/modern-media-controls/mute-support/mute-support-muted.html
Comment 9 Build Bot 2016-10-20 09:29:24 PDT 
Created attachment 292208 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 10 Antoine Quint 2016-10-31 07:19:10 PDT 
Created attachment 293417 [details]
Patch
Comment 11 Build Bot 2016-10-31 08:28:49 PDT 
Comment on attachment 293417 [details]
Patch

Attachment 293417 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2411378

New failing tests:
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/pip-support/pip-support-click.html
Comment 12 Build Bot 2016-10-31 08:28:53 PDT 
Created attachment 293420 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 13 Build Bot 2016-10-31 08:37:51 PDT 
Comment on attachment 293417 [details]
Patch

Attachment 293417 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2411450

New failing tests:
media/modern-media-controls/start-support/start-support-no-source.html
media/modern-media-controls/volume-support/volume-support-media-api.html
media/modern-media-controls/volume-support/volume-support-media-api-mute.html
media/modern-media-controls/playback-support/playback-support-autoplay.html
media/modern-media-controls/volume-support/volume-support-click.html
media/modern-media-controls/mute-support/mute-support-muted.html
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/start-support/start-support-error.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/scrubber-support/scrubber-support-media-api.html
media/modern-media-controls/remaining-time-support/remaining-time-support.html
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
media/modern-media-controls/pip-support/pip-support-click.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/volume-support/volume-support-drag.html
media/modern-media-controls/media-controller/media-controller-constructor.html
media/modern-media-controls/mute-support/mute-support-media-api.html
media/modern-media-controls/mute-support/mute-support-button-click.html
media/modern-media-controls/playback-support/playback-support-media-api.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/start-support/start-support-autoplay.html
media/modern-media-controls/elapsed-time-support/elapsed-time-support.html
Comment 14 Build Bot 2016-10-31 08:37:54 PDT 
Created attachment 293421 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 15 Build Bot 2016-10-31 09:29:46 PDT 
Comment on attachment 293417 [details]
Patch

Attachment 293417 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2411554

New failing tests:
media/modern-media-controls/start-support/start-support-no-source.html
media/modern-media-controls/volume-support/volume-support-media-api.html
media/modern-media-controls/volume-support/volume-support-media-api-mute.html
media/modern-media-controls/playback-support/playback-support-autoplay.html
media/modern-media-controls/volume-support/volume-support-click.html
media/modern-media-controls/mute-support/mute-support-muted.html
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/start-support/start-support-error.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/scrubber-support/scrubber-support-media-api.html
media/modern-media-controls/remaining-time-support/remaining-time-support.html
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
media/modern-media-controls/pip-support/pip-support-click.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/volume-support/volume-support-drag.html
media/modern-media-controls/media-controller/media-controller-constructor.html
media/modern-media-controls/mute-support/mute-support-media-api.html
media/modern-media-controls/mute-support/mute-support-button-click.html
media/modern-media-controls/playback-support/playback-support-media-api.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/start-support/start-support-autoplay.html
media/modern-media-controls/elapsed-time-support/elapsed-time-support.html
Comment 16 Build Bot 2016-10-31 09:29:49 PDT 
Created attachment 293427 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 17 Build Bot 2016-10-31 11:04:48 PDT 
Comment on attachment 293417 [details]
Patch

Attachment 293417 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2412161

New failing tests:
media/modern-media-controls/start-support/start-support-no-source.html
media/modern-media-controls/volume-support/volume-support-media-api.html
media/modern-media-controls/volume-support/volume-support-media-api-mute.html
media/modern-media-controls/playback-support/playback-support-autoplay.html
media/modern-media-controls/volume-support/volume-support-click.html
media/modern-media-controls/mute-support/mute-support-muted.html
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/start-support/start-support-error.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/scrubber-support/scrubber-support-media-api.html
media/modern-media-controls/remaining-time-support/remaining-time-support.html
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
media/modern-media-controls/pip-support/pip-support-click.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/volume-support/volume-support-drag.html
media/modern-media-controls/media-controller/media-controller-constructor.html
media/modern-media-controls/mute-support/mute-support-media-api.html
media/modern-media-controls/mute-support/mute-support-button-click.html
media/modern-media-controls/playback-support/playback-support-media-api.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/start-support/start-support-autoplay.html
media/modern-media-controls/elapsed-time-support/elapsed-time-support.html
Comment 18 Build Bot 2016-10-31 11:04:52 PDT 
Created attachment 293438 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 19 Build Bot 2016-10-31 11:30:56 PDT 
Comment on attachment 293417 [details]
Patch

Attachment 293417 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2412141

New failing tests:
media/modern-media-controls/start-support/start-support-no-source.html
media/modern-media-controls/volume-support/volume-support-media-api.html
media/modern-media-controls/volume-support/volume-support-media-api-mute.html
media/modern-media-controls/playback-support/playback-support-autoplay.html
media/modern-media-controls/volume-support/volume-support-click.html
media/modern-media-controls/mute-support/mute-support-muted.html
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/start-support/start-support-error.html
media/modern-media-controls/start-support/start-support-click-to-start.html
media/modern-media-controls/scrubber-support/scrubber-support-media-api.html
media/modern-media-controls/remaining-time-support/remaining-time-support.html
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
media/modern-media-controls/pip-support/pip-support-click.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/volume-support/volume-support-drag.html
media/modern-media-controls/media-controller/media-controller-constructor.html
media/modern-media-controls/mute-support/mute-support-media-api.html
media/modern-media-controls/mute-support/mute-support-button-click.html
media/modern-media-controls/playback-support/playback-support-media-api.html
media/modern-media-controls/start-support/start-support-manual-play.html
media/modern-media-controls/playback-support/playback-support-button-click.html
media/modern-media-controls/start-support/start-support-autoplay.html
media/modern-media-controls/elapsed-time-support/elapsed-time-support.html
Comment 20 Build Bot 2016-10-31 11:30:59 PDT 
Created attachment 293443 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 21 Dean Jackson 2016-10-31 11:37:29 PDT 
Comment on attachment 293417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=293417&action=review

> LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html:51
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/airplay-button.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/button.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/buttons-container.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-button.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/media-controls.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/placard.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/scrubber.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/slider.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/start-button.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/time-label.css">
> +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/volume-slider.css">
> +<script src="../../../resources/js-test-pre.js"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/scheduler.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/layout-node.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/layout-item.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/buttons-container.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-service.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/start-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/play-pause-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/skip-back-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/airplay-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/pip-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/fullscreen-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/mute-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/tracks-button.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/slider.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/volume-slider.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/scrubber.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/time-label.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/time-control.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/placard.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/airplay-placard.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/pip-placard.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/media-controls.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/macos-media-controls.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/media-controller-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/elapsed-time-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/mute-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/pip-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/playback-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/remaining-time-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/scrubbing-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/skip-back-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/start-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/volume-support.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/media-controller.js" type="text/javascript"></script>
> +<script src="../../../../Source/WebCore/Modules/modern-media-controls/main.js" type="text/javascript"></script>

This is out of control. We need to investigate the build script. Although I guess you can't load from DerivedSources.... not sure how to fix this.
Comment 22 Antoine Quint 2016-10-31 12:21:54 PDT 
(In reply to comment #21)
> Comment on attachment 293417 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=293417&action=review
> 
> > LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html:51
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/airplay-button.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/button.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/buttons-container.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-button.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/media-controls.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/placard.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/scrubber.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/slider.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/start-button.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/time-label.css">
> > +<link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/volume-slider.css">
> > +<script src="../../../resources/js-test-pre.js"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/scheduler.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/layout-node.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/layout-item.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/buttons-container.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-service.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/start-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/play-pause-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/skip-back-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/airplay-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/pip-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/fullscreen-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/mute-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/tracks-button.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/slider.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/volume-slider.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/scrubber.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/time-label.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/time-control.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/placard.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/airplay-placard.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/pip-placard.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/media-controls.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/macos-media-controls.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/macos-inline-media-controls.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/media-controller-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/elapsed-time-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/mute-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/pip-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/playback-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/remaining-time-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/scrubbing-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/skip-back-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/start-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/volume-support.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/media/media-controller.js" type="text/javascript"></script>
> > +<script src="../../../../Source/WebCore/Modules/modern-media-controls/main.js" type="text/javascript"></script>
> 
> This is out of control. We need to investigate the build script. Although I
> guess you can't load from DerivedSources.... not sure how to fix this.

I'll have a testing utility up for review tomorrow hopefully that will address this. The scripts and CSS files will be added dynamically based on the js-files in the WebCore module.
Comment 23 Antoine Quint 2016-10-31 14:56:45 PDT 
Created attachment 293468 [details]
Patch
Comment 24 Antoine Quint 2016-10-31 15:23:35 PDT 
Created attachment 293476 [details]
Patch
Comment 25 Build Bot 2016-10-31 16:32:28 PDT 
Comment on attachment 293476 [details]
Patch

Attachment 293476 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2415625

New failing tests:
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/pip-support/pip-support-click.html
Comment 26 Build Bot 2016-10-31 16:32:31 PDT 
Created attachment 293489 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 27 Build Bot 2016-10-31 16:33:27 PDT 
Comment on attachment 293476 [details]
Patch

Attachment 293476 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2415803

New failing tests:
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/pip-support/pip-support-click.html
Comment 28 Build Bot 2016-10-31 16:33:30 PDT 
Created attachment 293491 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 29 Build Bot 2016-10-31 18:00:14 PDT 
Comment on attachment 293476 [details]
Patch

Attachment 293476 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2416693

New failing tests:
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/pip-support/pip-support-click.html
Comment 30 Build Bot 2016-10-31 18:00:20 PDT 
Created attachment 293507 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 31 Antoine Quint 2016-11-01 02:59:00 PDT 
Created attachment 293542 [details]
Patch
Comment 32 Antoine Quint 2016-11-01 03:20:11 PDT 
Created attachment 293545 [details]
Patch
Comment 33 Antoine Quint 2016-11-01 03:21:12 PDT 
Created attachment 293546 [details]
Patch for landing
Comment 34 WebKit Commit Bot 2016-11-01 03:23:19 PDT 
Comment on attachment 293546 [details]
Patch for landing

Rejecting attachment 293546 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 293546, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
aving rejects to file LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api-mute.html.rej
patching file LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api.html
Hunk #1 FAILED at 29.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/media/modern-media-controls/volume-support/volume-support-media-api.html.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2426191
Comment 35 Antoine Quint 2016-11-01 11:59:51 PDT 
Created attachment 293563 [details]
Patch
Comment 36 Build Bot 2016-11-01 12:38:44 PDT 
Comment on attachment 293563 [details]
Patch

Attachment 293563 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2445239

New failing tests:
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/pip-support/pip-support-click.html
Comment 37 Build Bot 2016-11-01 12:38:48 PDT 
Created attachment 293569 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 38 Build Bot 2016-11-01 13:04:48 PDT 
Comment on attachment 293563 [details]
Patch

Attachment 293563 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2445363

New failing tests:
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/pip-support/pip-support-click.html
svg/wicd/test-rightsizing-b.xhtml
Comment 39 Build Bot 2016-11-01 13:04:52 PDT 
Created attachment 293574 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 40 Build Bot 2016-11-01 13:11:32 PDT 
Comment on attachment 293563 [details]
Patch

Attachment 293563 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2445366

New failing tests:
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/pip-support/pip-support-click.html
Comment 41 Build Bot 2016-11-01 13:11:36 PDT 
Created attachment 293580 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 42 Build Bot 2016-11-01 13:16:29 PDT 
Comment on attachment 293563 [details]
Patch

Attachment 293563 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2445371

New failing tests:
media/modern-media-controls/pip-support/pip-support-enabled.html
media/modern-media-controls/pip-support/pip-support-click.html
Comment 43 Build Bot 2016-11-01 13:16:33 PDT 
Created attachment 293582 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 44 Antoine Quint 2016-11-01 14:07:45 PDT 
Created attachment 293592 [details]
Patch
Comment 45 Antoine Quint 2016-11-01 14:14:34 PDT 
Created attachment 293595 [details]
Patch
Comment 46 Antoine Quint 2016-11-01 23:42:20 PDT 
Created attachment 293643 [details]
Patch
Comment 47 Antoine Quint 2016-11-02 00:24:31 PDT 
Created attachment 293646 [details]
Patch for landing
Comment 48 WebKit Commit Bot 2016-11-02 01:01:40 PDT 
Comment on attachment 293646 [details]
Patch for landing

Clearing flags on attachment: 293646

Committed r208271: <http://trac.webkit.org/changeset/208271>
Comment 49 WebKit Commit Bot 2016-11-02 01:01:47 PDT 
All reviewed patches have been landed.  Closing bug.