Bug 163727 – [Modern Media Controls] Media Controller: volume control support

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

We need to update the media's volume as the user interacts with the volume control and update the volume control if the volume is changed via the media API.

[Antoine Quint]

<rdar://problem/27989482>

[Antoine Quint]

Created attachment 292178 [details]
Patch

[Antoine Quint]

Tests aren't ready yet but the code can already be reviewed.

[Dean Jackson]

Comment on attachment 292178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292178&action=review

> Source/WebCore/ChangeLog:14
> +        * Modules/modern-media-controls/media/volume-support.js: Copied from Source/WebCore/Modules/modern-media-controls/media/media-controller.js.

Any ideas what to do with this line?

> Source/WebCore/Modules/modern-media-controls/media/volume-support.js:44
> +    controlValueWillStartChanging(control)
> +    {
> +        this.mediaController.media.muted = false;
> +    }

I think maybe we should set muted to true if we end up with a volume of zero.

[Antoine Quint]

(In reply to comment #4)
> Comment on attachment 292178 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=292178&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        * Modules/modern-media-controls/media/volume-support.js: Copied from Source/WebCore/Modules/modern-media-controls/media/media-controller.js.
> 
> Any ideas what to do with this line?

I'll have to dig deeper into this issue, will get back to you within 5 business days.

> > Source/WebCore/Modules/modern-media-controls/media/volume-support.js:44
> > +    controlValueWillStartChanging(control)
> > +    {
> > +        this.mediaController.media.muted = false;
> > +    }
> 
> I think maybe we should set muted to true if we end up with a volume of zero.

I wonder. In my mind the muted state and volume are not connected. Imagine that we set muted to true when volume = 0, then clicking the muted button to unmute, which simply toggles the muted property on the media, wouldn't change much of anything.

[Antoine Quint]

Created attachment 293238 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 293238 [details]
Patch for landing

Clearing flags on attachment: 293238

Committed r208080: <http://trac.webkit.org/changeset/208080>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.