Bug 163726 – [Modern Media Controls] Media Controller: scrubbing support

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

Make the time control scrubber reflect the media's current time and update the media current time as the user interacts with the scrubber.

[Antoine Quint]

<rdar://problem/27989481>

[Antoine Quint]

Created attachment 292175 [details]
Patch

[Antoine Quint]

Tests to follow, but the code can be reviewed in the meantime.

[Dean Jackson]

Comment on attachment 292175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292175&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:263
> +            NSArray *mediaPaths = @[@"media-controller-support", @"mute-support", @"scrubbing-support", @"start-support", @"media-controller"];

This is getting a bit big. I think you should have a build step that generates a single file first, which is loaded from here. That saves us calling stringWithContentsOfFile so many times.

[Antoine Quint]

(In reply to comment #4)
> Comment on attachment 292175 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=292175&action=review
> 
> > Source/WebCore/rendering/RenderThemeMac.mm:263
> > +            NSArray *mediaPaths = @[@"media-controller-support", @"mute-support", @"scrubbing-support", @"start-support", @"media-controller"];
> 
> This is getting a bit big. I think you should have a build step that
> generates a single file first, which is loaded from here. That saves us
> calling stringWithContentsOfFile so many times.

Good point, there is no need to do this at runtime, except maybe to only have certain platform-specific (macOS vs. iOS) files loaded based on the platform at runtime, but even that can be done by generating two different CSS and JS files for macOS vs. iOS. I'll take a crack at it.

[Antoine Quint]

Some of the new tests are skipped on iOS due to using eventSender, see https://bugs.webkit.org/show_bug.cgi?id=164088.

[Antoine Quint]

Created attachment 293071 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 293071 [details]
Patch for landing

Rejecting attachment 293071 [details] from commit-queue.

New failing tests:
http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
media/modern-media-controls/scrubber-support/scrubber-support-click.html
Full output: http://webkit-queues.webkit.org/results/2388810

[WebKit Commit Bot]

Created attachment 293079 [details]
Archive of layout-test-results from webkit-cq-01 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 293126 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 293126 [details]
Patch for landing

Rejecting attachment 293126 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 293126, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
g file LayoutTests/media/modern-media-controls/start-support/start-support-no-source.html
patching file LayoutTests/platform/ios-simulator/TestExpectations
Hunk #1 succeeded at 2705 (offset 3 lines).
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1455.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2391464

[Antoine Quint]

Created attachment 293128 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 293128 [details]
Patch for landing

Clearing flags on attachment: 293128

Committed r208042: <http://trac.webkit.org/changeset/208042>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.