RESOLVED FIXED 163715
Passing a number as the pixel parameter to texImage2D() doesn't thrown an exception 
https://bugs.webkit.org/show_bug.cgi?id=163715
Summary Passing a number as the pixel parameter to texImage2D() doesn't thrown an exc...
Myles C. Maxfield
Reported 2016-10-19 18:29:53 PDT
The IDL bindings code converts the argument ArrayBufferView? pixels to auto pixels = toArrayBufferView(state->uncheckedArgument(8)); inside JSWebGLRenderingContextBase.cpp toArrayBufferView returns nullptr if the input is a wrong type, so this case is indistinguishable from passing "null" in javascript. However, passing an unknown type should throw an exception, and passing "null" should cause "a buffer of sufficient size initialized to 0 is passed."
Attachments
Test (5.08 KB, patch)
2016-10-20 10:15 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (8.34 KB, patch)
2016-10-20 11:51 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2016-10-20 10:15:24 PDT
Created attachment 292219 [details] Test
Chris Dumez
Comment 3 2016-10-20 10:23:43 PDT
Thanks, I am looking into it.
Chris Dumez
Comment 4 2016-10-20 11:51:16 PDT
Created attachment 292233 [details] Patch
Myles C. Maxfield
Comment 5 2016-10-20 12:17:18 PDT
👏
WebKit Commit Bot
Comment 6 2016-10-20 12:55:01 PDT
Comment on attachment 292233 [details] Patch Clearing flags on attachment: 292233 Committed r207634: <http://trac.webkit.org/changeset/207634>
WebKit Commit Bot
Comment 7 2016-10-20 12:55:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.