WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
163708
Shapes tests look like they fail because getPropertyValue() returns ""
https://bugs.webkit.org/show_bug.cgi?id=163708
Summary
Shapes tests look like they fail because getPropertyValue() returns ""
Dean Jackson
Reported
2016-10-19 17:00:08 PDT
A lot of the W3C CSS Shapes tests fail because "" !=== null. Check the expected results for FAIL entries. We need to send a patch to W3C/CSS. My reading of the CSS OM specification says we are correct and the test is wrong.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-10-19 17:01:54 PDT
<
rdar://problem/28859137
>
Dean Jackson
Comment 2
2016-10-19 17:20:39 PDT
Once that's confirmed and landed, re-import the W3C tests.
Dean Jackson
Comment 3
2016-10-19 17:20:57 PDT
./Tools/Scripts/import-w3c-tests ../csswg-test/ -t css-shapes-1 -d imported/w3c/csswg-test/
Ahmad Saleem
Comment 4
2022-10-01 14:54:02 PDT
I don't think this might an issue as of right now since all W3C tests are now on WPT and Safari Technology Preview 154 do better than other browsers:
https://wpt.fyi/results/css/css-shapes?label=master&label=experimental&aligned&view=subtest&q=css%20shapes
Do we need to look into it? Thanks!
Sam Sneddon [:gsnedders]
Comment 5
2023-06-05 14:58:59 PDT
Seems like there's basically no usage of getPropertyValue any more, so yeah, this is fixed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug