Bug 163708 - Shapes tests look like they fail because getPropertyValue() returns ""
Summary: Shapes tests look like they fail because getPropertyValue() returns ""
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-19 17:00 PDT by Dean Jackson
Modified: 2023-06-05 14:58 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-10-19 17:00:08 PDT
A lot of the W3C CSS Shapes tests fail because "" !=== null.
Check the expected results for FAIL entries.

We need to send a patch to W3C/CSS. My reading of the CSS OM specification says we are correct and the test is wrong.
Comment 1 Radar WebKit Bug Importer 2016-10-19 17:01:54 PDT
<rdar://problem/28859137>
Comment 2 Dean Jackson 2016-10-19 17:20:39 PDT
Once that's confirmed and landed, re-import the W3C tests.
Comment 3 Dean Jackson 2016-10-19 17:20:57 PDT
./Tools/Scripts/import-w3c-tests ../csswg-test/ -t css-shapes-1 -d imported/w3c/csswg-test/
Comment 4 Ahmad Saleem 2022-10-01 14:54:02 PDT
I don't think this might an issue as of right now since all W3C tests are now on WPT and Safari Technology Preview 154 do better than other browsers:

https://wpt.fyi/results/css/css-shapes?label=master&label=experimental&aligned&view=subtest&q=css%20shapes

Do we need to look into it? Thanks!
Comment 5 Sam Sneddon [:gsnedders] 2023-06-05 14:58:59 PDT
Seems like there's basically no usage of getPropertyValue any more, so yeah, this is fixed.