Bug 163695 – Add support for sequences and dictionaries in unions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Add support for sequences and dictionaries in unions

[Sam Weinig]

Created attachment 292113 [details]
Patch

[WebKit Commit Bot]

Attachment 292113 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:481:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:482:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:487:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:488:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:492:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:493:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:497:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:498:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:502:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:503:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:524:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:569:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:582:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/bindings/js/JSDOMConvert.h:592:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 14 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Comment on attachment 292113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292113&action=review

> Source/WebCore/testing/TypeConversions.idl:58
> +    readonly attribute DOMString typeConversionsDictionaryUnionType; // Returns one of the following strings: "Node", "sequence<DOMString>", "Dictionary"." 

Seems like this should use an IDL string enumeration?

> LayoutTests/js/dom/webidl-type-mapping.html:596
> +// Test (DOMString or sequence<DOMString>)

I do not understand this comment. it seems to test something else.

[Sam Weinig]

(In reply to comment #3)
> Comment on attachment 292113 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=292113&action=review
> 
> > Source/WebCore/testing/TypeConversions.idl:58
> > +    readonly attribute DOMString typeConversionsDictionaryUnionType; // Returns one of the following strings: "Node", "sequence<DOMString>", "Dictionary"." 
> 
> Seems like this should use an IDL string enumeration?
> 
> > LayoutTests/js/dom/webidl-type-mapping.html:596
> > +// Test (DOMString or sequence<DOMString>)
> 
> I do not understand this comment. it seems to test something else.

Oops. From an earlier version. Fixed.

[Sam Weinig]

Committed r207575: <http://trac.webkit.org/changeset/207575>

[Jiewen Tan]

*** Bug 163619 has been marked as a duplicate of this bug. ***

[Jiewen Tan]

*** Bug 163614 has been marked as a duplicate of this bug. ***