Bug 163673 - Move HTML Interactive Form Validation behind an experimental flag
Summary: Move HTML Interactive Form Validation behind an experimental flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks: 164382
  Show dependency tree / graph
 
Reported: 2016-10-19 11:09 PDT by Chris Dumez
Modified: 2016-11-07 09:46 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.12 KB, patch)
2016-10-19 11:50 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-19 11:09:15 PDT 
Move Interactive Form Validation behind an experimental flag and disable by default until by have a better UI.
Comment 1 Chris Dumez 2016-10-19 11:50:45 PDT 
Created attachment 292089 [details]
Patch
Comment 2 Daniel Bates 2016-10-19 13:29:29 PDT 
Comment on attachment 292089 [details]
Patch

Notice that interactive form validation is enabled in DumpRenderTree and WebKitTestRunner. Did you intend to keep them enabled by default in these test tools?
Comment 3 Chris Dumez 2016-10-19 13:31:04 PDT 
(In reply to comment #2)
> Comment on attachment 292089 [details]
> Patch
> 
> Notice that interactive form validation is enabled in DumpRenderTree and
> WebKitTestRunner. Did you intend to keep them enabled by default in these
> test tools?

Sure, we need them for testing. They were always enabled there. I only turned on the feature on for Safari recently so I am basically rolling back my recent change.
Comment 4 Chris Dumez 2016-10-19 13:31:46 PDT 
Comment on attachment 292089 [details]
Patch

Clearing flags on attachment: 292089

Committed r207562: <http://trac.webkit.org/changeset/207562>
Comment 5 Chris Dumez 2016-10-19 13:31:51 PDT 
All reviewed patches have been landed.  Closing bug.