Bug 163667 - Wrong blur radius for filter: drop-shadow()
Summary: Wrong blur radius for filter: drop-shadow()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-19 09:53 PDT by Simon Fraser (smfr)
Modified: 2016-10-28 11:37 PDT (History)
5 users (show)

See Also:

Attachments
Testcase (1.24 KB, text/html)
2016-10-19 09:53 PDT, Simon Fraser (smfr) 		no flags Details
Patch (6.38 KB, patch)
2016-10-27 22:40 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-10-19 09:53:00 PDT 
Created attachment 292075 [details]
Testcase

The blur radius for filter: drop-shadow() should match SVG's feGaussianBlur stdDeviation, which is different from box-shadow. We get this wrong.

More info at https://dbaron.org/log/20110225-blur-radius
Comment 1 Simon Fraser (smfr) 2016-10-19 09:54:42 PDT 
And the radius changes when you drop into compositing :(
Comment 2 Simon Fraser (smfr) 2016-10-27 21:47:37 PDT 
So it turns out that feDropShadow is wrong; it's passing the stdDev directly to ShadowBlur as "blur radius", which is intended for the box-shadow use case.
Comment 3 Simon Fraser (smfr) 2016-10-27 22:40:16 PDT 
Created attachment 293117 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-28 11:37:10 PDT 
Comment on attachment 293117 [details]
Patch

Clearing flags on attachment: 293117

Committed r208058: <http://trac.webkit.org/changeset/208058>
Comment 5 WebKit Commit Bot 2016-10-28 11:37:15 PDT 
All reviewed patches have been landed.  Closing bug.