Bug 163662 – [CSS Parser] Fix named color parsing

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

Named color parsing in the old parser for extended colors relied on constructing a Color with the name and doing a lookup that way. This was bad in that serialization on the back end loses the extended color name.

The new parser allows the back end to hold a primitive identifier value for extended colors (making serialization correct). StyleColor contains a helper function for looking up the correct color.

This patch switches both the old and the new parsers over to the new StyleColor function.

[Dave Hyatt]

Created attachment 292067 [details]
Patch

[WebKit Commit Bot]

Attachment 292067 [details] did not pass style-queue:


ERROR: Source/WebCore/css/StyleResolver.cpp:123:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Landed in r207539.

[Darin Adler]

Comment on attachment 292067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292067&action=review

> Source/WebCore/css/StyleResolver.cpp:1817
> +    default: {
> +        return StyleColor::colorFromKeyword(ident);
> +    }

No need for these braces.