Bug 163634 - Add an beforeunload alert to the WebKitLegacy MiniBrowser
Summary: Add an beforeunload alert to the WebKitLegacy MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-18 17:12 PDT by Anders Carlsson
Modified: 2016-10-18 17:24 PDT (History)
0 users

See Also:

Attachments
Patch (1.73 KB, patch)
2016-10-18 17:13 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-10-18 17:12:29 PDT 
Add an beforeunload alert to the WebKitLegacy MiniBrowser
Comment 1 Anders Carlsson 2016-10-18 17:13:50 PDT 
Created attachment 292007 [details]
Patch
Comment 2 Sam Weinig 2016-10-18 17:16:58 PDT 
Comment on attachment 292007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292007&action=review

> Tools/MiniBrowser/mac/WK1BrowserWindowController.m:376
> +    NSAlert* alert = [[NSAlert alloc] init];

* on the wrong side.
Comment 3 Sam Weinig 2016-10-18 17:17:51 PDT 
Comment on attachment 292007 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292007&action=review

> Tools/MiniBrowser/mac/WK1BrowserWindowController.m:379
> +    [alert setMessageText:[NSString stringWithFormat:@"JavaScript before unload dialog from %@.", frame.dataSource.request.URL.absoluteString]];
> +    [alert setInformativeText:message];

Should use property notation.
Comment 4 Anders Carlsson 2016-10-18 17:24:47 PDT 
Committed r207508: <http://trac.webkit.org/changeset/207508>