Bug 163630 - [Web IDL] Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitializedByEventConstructor]
Summary: [Web IDL] Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitial...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-18 16:29 PDT by Chris Dumez
Modified: 2016-10-18 19:29 PDT (History)
10 users (show)

See Also:


Attachments
Patch (12.75 KB, patch)
2016-10-18 16:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (20.34 KB, patch)
2016-10-18 17:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.03 MB, application/zip)
2016-10-18 18:10 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews102 for mac-yosemite (1.07 MB, application/zip)
2016-10-18 18:14 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-yosemite (1.72 MB, application/zip)
2016-10-18 18:18 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (9.24 MB, application/zip)
2016-10-18 18:19 PDT, Build Bot
no flags Details
Patch (26.55 KB, patch)
2016-10-18 19:03 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-18 16:29:44 PDT
Kill support for [LegacyConstructorTemplate=Event] / [LegacyInitializedByEventConstructor] in our IDL. All our events should use proper constructors.
Comment 1 Chris Dumez 2016-10-18 16:33:11 PDT
Created attachment 292000 [details]
Patch
Comment 2 Chris Dumez 2016-10-18 17:01:17 PDT
Created attachment 292006 [details]
Patch
Comment 3 Chris Dumez 2016-10-18 17:05:33 PDT
Finally \o/
Comment 4 Darin Adler 2016-10-18 17:11:16 PDT
Comment on attachment 292006 [details]
Patch

I’m surprised that you didn’t have to rename EventInit to Event::Init and UIEventInit to UIEvent::Init.
Comment 5 Chris Dumez 2016-10-18 17:14:04 PDT
(In reply to comment #4)
> Comment on attachment 292006 [details]
> Patch
> 
> I’m surprised that you didn’t have to rename EventInit to Event::Init and
> UIEventInit to UIEvent::Init.

Because they are defined in their own idl file.
Comment 6 Build Bot 2016-10-18 18:10:12 PDT
Comment on attachment 292006 [details]
Patch

Attachment 292006 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2319490

New failing tests:
fast/events/constructors/event-constructors.html
fast/events/constructors/ui-event-constructor.html
Comment 7 Build Bot 2016-10-18 18:10:16 PDT
Created attachment 292016 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-10-18 18:14:14 PDT
Comment on attachment 292006 [details]
Patch

Attachment 292006 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2319535

New failing tests:
fast/events/constructors/event-constructors.html
fast/events/constructors/ui-event-constructor.html
Comment 9 Build Bot 2016-10-18 18:14:18 PDT
Created attachment 292018 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Build Bot 2016-10-18 18:17:57 PDT
Comment on attachment 292006 [details]
Patch

Attachment 292006 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2319482

New failing tests:
fast/events/constructors/event-constructors.html
fast/events/constructors/ui-event-constructor.html
Comment 11 Build Bot 2016-10-18 18:18:01 PDT
Created attachment 292019 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 12 Build Bot 2016-10-18 18:19:30 PDT
Comment on attachment 292006 [details]
Patch

Attachment 292006 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2319492

New failing tests:
fast/events/constructors/event-constructors.html
fast/events/constructors/ui-event-constructor.html
Comment 13 Build Bot 2016-10-18 18:19:34 PDT
Created attachment 292020 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 14 Chris Dumez 2016-10-18 19:03:34 PDT
Created attachment 292024 [details]
Patch
Comment 15 WebKit Commit Bot 2016-10-18 19:29:33 PDT
Comment on attachment 292024 [details]
Patch

Clearing flags on attachment: 292024

Committed r207515: <http://trac.webkit.org/changeset/207515>
Comment 16 WebKit Commit Bot 2016-10-18 19:29:39 PDT
All reviewed patches have been landed.  Closing bug.