Bug 163627 - Add a MiniBrowser menu item to apply page scale in WK1 and WK2
Summary: Add a MiniBrowser menu item to apply page scale in WK1 and WK2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-18 15:37 PDT by Simon Fraser (smfr)
Modified: 2016-10-18 18:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (25.16 KB, patch)
2016-10-18 15:38 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (25.16 KB, patch)
2016-10-18 16:53 PDT, Simon Fraser (smfr) 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-10-18 15:37:10 PDT 
Add a MiniBrowser menu item to apply page scale in WK1 and WK2
Comment 1 Simon Fraser (smfr) 2016-10-18 15:38:32 PDT 
Created attachment 291994 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-18 15:40:51 PDT 
Attachment 291994 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebViewPrivate.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
ERROR: Tools/MiniBrowser/mac/BrowserWindowController.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2016-10-18 16:53:13 PDT 
Created attachment 292004 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-18 16:54:35 PDT 
Attachment 292004 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebViewPrivate.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
ERROR: Tools/MiniBrowser/mac/BrowserWindowController.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Dean Jackson 2016-10-18 18:01:56 PDT 
Comment on attachment 292004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=292004&action=review

> Tools/MiniBrowser/mac/BrowserWindowController.m:170
> +    if (tag == 1)
> +        return 1;
> +    if (tag == 2)
> +        return 1.25;
> +    if (tag == 3)
> +        return 1.5;
> +    if (tag == 4)
> +        return 2.0;
> +

Nothing < 1?
Comment 6 Simon Fraser (smfr) 2016-10-18 18:06:54 PDT 
https://trac.webkit.org/changeset/207512