163626 – Replace std::experimental::variant with WTF::Variant (or similar)

RESOLVED FIXED Bug 163626

Replace std::experimental::variant with WTF::Variant (or similar)

https://bugs.webkit.org/show_bug.cgi?id=163626

Summary Replace std::experimental::variant with WTF::Variant (or similar)

Antti Koivisto

Reported 2016-10-18 15:26:31 PDT

std::experimental::variant looks ugly. Maybe we should have a WTF alias until it is in std namespace?

Attachments
Patch (50.34 KB, patch) 2016-10-18 17:57 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (51.89 KB, patch) 2016-10-18 18:13 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2016-10-18 17:57:03 PDT

Created attachment 292013 [details] Patch

WebKit Commit Bot

Comment 2 2016-10-18 17:59:12 PDT

Attachment 292013 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:42: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:42: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:51: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:58: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:59: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:66: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Source/WTF/wtf/Variant.h:207: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:207: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:226: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:229: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:246: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:381: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:706: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1440: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1442: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1444: __copy_construct_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1445: __copy_assign_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1446: __move_construct_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1447: __move_assign_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1448: __destroy_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1473: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1473: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1473: __move_construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1473: __other is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1477: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1482: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1482: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1482: __copy_construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1482: __other is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1486: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1539: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1544: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1546: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1551: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1553: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1558: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1561: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1571: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1579: __x is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1592: __x is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1601: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1601: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1630: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1655: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1672: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Variant.h:1672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Variant.h:1678: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1714: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1717: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Variant.h:1717: __temp is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1725: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1736: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1736: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1751: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1751: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1754: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1754: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1757: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1757: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1760: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1760: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1766: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1766: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1771: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1771: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1776: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1776: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1781: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1781: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1787: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1787: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1787: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1790: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1796: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1796: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1796: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1799: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1805: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1805: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1805: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1807: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Variant.h:1807: Missing spaces around != [whitespace/operators] [3] ERROR: Source/WTF/wtf/Variant.h:1812: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1812: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1812: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1814: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Variant.h:1814: Missing spaces around != [whitespace/operators] [3] ERROR: Source/WTF/wtf/Variant.h:1819: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1824: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1829: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1829: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1836: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1842: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1880: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1880: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1880: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1882: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1946: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1954: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1991: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1991: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1991: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1994: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Variant.h:1999: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1999: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1999: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2004: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:2004: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2004: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2008: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Variant.h:2013: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:2013: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2013: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2018: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:2018: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2018: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2023: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:2023: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2023: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2027: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2027: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2029: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2029: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2030: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2030: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2031: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2031: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2032: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2032: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2033: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2033: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2034: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2034: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2048: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2049: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2055: Missing space before { [whitespace/braces] [5] Total errors found: 136 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 3 2016-10-18 18:13:51 PDT

Created attachment 292017 [details] Patch

WebKit Commit Bot

Comment 4 2016-10-18 18:14:58 PDT

Attachment 292017 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Variant.h:207: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:207: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:226: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:229: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:246: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:381: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:706: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1440: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1442: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1444: __copy_construct_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1445: __copy_assign_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1446: __move_construct_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1447: __move_assign_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1448: __destroy_op_table is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1473: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1473: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1473: __move_construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1473: __other is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1477: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1482: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1482: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1482: __copy_construct is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1482: __other is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1486: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1539: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1544: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1546: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1551: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1553: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1558: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1561: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1571: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1579: __x is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1592: __x is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1601: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1601: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1630: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1655: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1672: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] ERROR: Source/WTF/wtf/Variant.h:1672: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Variant.h:1678: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1714: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1717: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Variant.h:1717: __temp is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Variant.h:1725: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1736: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1736: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1751: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1751: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1754: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1754: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1757: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1757: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1760: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1760: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1766: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1766: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1771: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1771: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1776: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1776: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1781: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1781: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1787: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1787: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1787: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1790: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1796: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1796: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1796: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1799: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1805: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1805: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1805: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1807: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Variant.h:1807: Missing spaces around != [whitespace/operators] [3] ERROR: Source/WTF/wtf/Variant.h:1812: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1812: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1812: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1814: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] ERROR: Source/WTF/wtf/Variant.h:1814: Missing spaces around != [whitespace/operators] [3] ERROR: Source/WTF/wtf/Variant.h:1819: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1824: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1829: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1829: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1836: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1842: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1880: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1880: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1880: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1882: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1946: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1954: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1991: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1991: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1991: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:1994: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Variant.h:1999: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:1999: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:1999: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2004: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:2004: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2004: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2008: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/Variant.h:2013: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:2013: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2013: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2018: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:2018: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2018: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2023: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/wtf/Variant.h:2023: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2023: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2027: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2027: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2029: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2029: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2030: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2030: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2031: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2031: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2032: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2032: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2033: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2033: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2034: Missing space after , [whitespace/comma] [3] ERROR: Source/WTF/wtf/Variant.h:2034: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2048: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2049: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/Variant.h:2055: Missing space before { [whitespace/braces] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:42: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:42: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:51: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:58: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:59: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] ERROR: Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:66: Consider using EXPECT_EQ instead of EXPECT_TRUE(a == b) [readability/check] [2] Total errors found: 136 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 5 2016-10-18 19:46:28 PDT

Comment on attachment 292017 [details] Patch Clearing flags on attachment: 292017 Committed r207517: <http://trac.webkit.org/changeset/207517>

WebKit Commit Bot

Comment 6 2016-10-18 19:46:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component Web Template Framework

Assignee

Sam Weinig

Reported

2016-10-18 15:26 PDT

Modified

2016-10-18 19:46 PDT History

CC List

2 users Show

URL

Keywords

Depends on

Blocks