Simplify SerializedScriptValue, MessagePortArray and ArrayBufferArray to ease generation
Created attachment 291992 [details] Patch
Attachment 291992 [details] did not pass style-queue: ERROR: Source/WebCore/dom/MessagePort.cpp:196: Omit int when using unsigned [runtime/unsigned] [1] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 291992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291992&action=review r=me > Source/WebCore/bindings/js/JSMessagePortCustom.h:60 > + extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray); uncheckedArgument(1)
(In reply to comment #3) > Comment on attachment 291992 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=291992&action=review > > r=me > > > Source/WebCore/bindings/js/JSMessagePortCustom.h:60 > > + extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray); > > uncheckedArgument(1) I don't think we can. We are only checking that the argument count is at least 1.
Committed r207505: <http://trac.webkit.org/changeset/207505>
Comment on attachment 291992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291992&action=review >>> Source/WebCore/bindings/js/JSMessagePortCustom.h:60 >>> + extractTransferables(state, state.argument(1), messagePortArray, arrayBufferArray); >> >> uncheckedArgument(1) > > I don't think we can. We are only checking that the argument count is at least 1. Duh. Sorry I misread.