RESOLVED CONFIGURATION CHANGED 163621
[WebIDL] brigand::find<typename A, typename B> should be replaced with brigand::filter<typename A, typename B> in IDLUnion converter 
https://bugs.webkit.org/show_bug.cgi?id=163621
Summary [WebIDL] brigand::find<typename A, typename B> should be replaced with brigan...
Jiewen Tan
Reported 2016-10-18 14:49:01 PDT
[WebIDL] brigand::find<typename A, typename B> should be replaced with brigand::filter<typename A, typename B> in IDLUnion converter
Attachments
Patch (2.49 KB, patch)
2016-10-18 14:52 PDT, Jiewen Tan 		cdumez: review+
DetailsFormatted DiffDiff
Patch for landing (2.52 KB, patch)
2016-10-19 10:03 PDT, Jiewen Tan 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2016-10-18 14:52:52 PDT
Created attachment 291989 [details] Patch
Chris Dumez
Comment 2 2016-10-19 00:08:25 PDT
Comment on attachment 291989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291989&action=review > Source/WebCore/ChangeLog:8 > + No tests. Please mention in the change log that the change is from Sam.
Jiewen Tan
Comment 3 2016-10-19 10:03:13 PDT
Created attachment 292077 [details] Patch for landing
Jiewen Tan
Comment 4 2016-10-19 10:03:52 PDT
Comment on attachment 291989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=291989&action=review Thanks Chris for reviewing this patch. >> Source/WebCore/ChangeLog:8 >> + No tests. > > Please mention in the change log that the change is from Sam. Fixed.
WebKit Commit Bot
Comment 5 2016-10-19 17:08:46 PDT
Comment on attachment 292077 [details] Patch for landing Rejecting attachment 292077 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 292077, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: S/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/js/JSDOMConvert.h Hunk #1 FAILED at 475. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/js/JSDOMConvert.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2327368
Note You need to log in before you can comment on or make changes to this bug.