Bug 163617 – Add JSC option to show time spent in each optimization phase

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

This option would provide more detail than the reportXXXCompileTimes options.  It would show the times for each phase of DFG / FTL compilation.

[Michael Saboff]

Created attachment 291981 [details]
Patch

[Mark Lam]

Comment on attachment 291981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291981&action=review

> Source/JavaScriptCore/dfg/DFGPhase.h:82
> +        before = monotonicallyIncreasingTimeMS();

Given that the DFG can run on a separate JIT thread concurrently, should you be using currentCPUTime() instead?

[Saam Barati]

Comment on attachment 291981 [details]
Patch

r=me

[Michael Saboff]

(In reply to comment #2)
> Comment on attachment 291981 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291981&action=review
> 
> > Source/JavaScriptCore/dfg/DFGPhase.h:82
> > +        before = monotonicallyIncreasingTimeMS();
> 
> Given that the DFG can run on a separate JIT thread concurrently, should you
> be using currentCPUTime() instead?

All of the other time stats for the compiler tiers use monotonicallyIncreasingTime().  Given that the compilation threads "should" run without being preempted, I think we're fine.

[WebKit Commit Bot]

Comment on attachment 291981 [details]
Patch

Clearing flags on attachment: 291981

Committed r207491: <http://trac.webkit.org/changeset/207491>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.