Bug 163611 – [WebIDL] Allow sequences of dictionaries as members of other dictionaries and as parameters

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[WebIDL] Allow sequences of dictionaries as members of other dictionaries and as parameters

[Zan Dobersek]

Created attachment 291970 [details]
Patch

[Sam Weinig]

This makes me think that Converter<IDLDictionary<T>>::convert() should maybe return a T not Optional<T>.  I need to think through what the consequences of this would be.

[Chris Dumez]

(In reply to comment #2)
> This makes me think that Converter<IDLDictionary<T>>::convert() should maybe
> return a T not Optional<T>.  I need to think through what the consequences
> of this would be.

I think I made the switch to returning Optional a while back so we could return Nullopt in error cases. However, since then, we updated our dictionary code so that all our native dictionary structs must have a default constructor. Therefore, I think it is no longer necessary to return an Optional<>, we can just return { } instead.

So I agree with Sam.

[Chris Dumez]

@Zan: I am happy to make the code change if you want. Just let me know.

[Zan Dobersek]

(In reply to comment #4)
> @Zan: I am happy to make the code change if you want. Just let me know.

Saw it in bug #163624. Thanks!

With that this patch isn't needed anymore.