Bug 163598 - [mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky failure
Summary: [mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks: 164784
  Show dependency treegraph
 
Reported: 2016-10-18 09:23 PDT by Ryan Haddad
Modified: 2017-02-07 05:24 PST (History)
2 users (show)

See Also:


Attachments
Patch for landing (1.60 KB, patch)
2017-02-07 04:47 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-10-18 09:23:24 PDT
LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky failure

https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/builds/9152

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmacos-inline-media-controls%2Fmacos-inline-media-controls-buttons-styles.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles-actual.txt
@@ -62,4 +62,63 @@
 PASS successfullyParsed is true
 
 TEST COMPLETE
+PlayPauseButton
+PASS rgba(style.backgroundColor).r is 255
+PASS rgba(style.backgroundColor).g is 255
+PASS rgba(style.backgroundColor).b is 255
+PASS rgba(style.backgroundColor).a is within 0.001 of 0.572
+PASS style.height is "50px"
+PASS style.webkitMaskPositionY is "12px"
 
+SkipBackButton
+PASS rgba(style.backgroundColor).r is 255
+PASS rgba(style.backgroundColor).g is 255
+PASS rgba(style.backgroundColor).b is 255
+PASS rgba(style.backgroundColor).a is within 0.001 of 0.572
+PASS style.height is "50px"
+PASS style.webkitMaskPositionY is "10px"
+
+MuteButton
+PASS rgba(style.backgroundColor).r is 255
+PASS rgba(style.backgroundColor).g is 255
+PASS rgba(style.backgroundColor).b is 255
+PASS rgba(style.backgroundColor).a is within 0.001 of 0.572
+PASS style.height is "50px"
+PASS style.webkitMaskPositionY is "10px"
+
+AirplayButton
+PASS rgba(style.backgroundColor).r is 255
+PASS rgba(style.backgroundColor).g is 255
+PASS rgba(style.backgroundColor).b is 255
+PASS rgba(style.backgroundColor).a is within 0.001 of 0.572
+PASS style.height is "50px"
+PASS style.webkitMaskPositionY is "13px"
+
+PiPButton
+PASS rgba(style.backgroundColor).r is 255
+PASS rgba(style.backgroundColor).g is 255
+PASS rgba(style.backgroundColor).b is 255
+PASS rgba(style.backgroundColor).a is within 0.001 of 0.572
+PASS style.height is "50px"
+PASS style.webkitMaskPositionY is "13px"
+
+TracksButton
+PASS rgba(style.backgroundColor).r is 255
+PASS rgba(style.backgroundColor).g is 255
+PASS rgba(style.backgroundColor).b is 255
+PASS rgba(style.backgroundColor).a is within 0.001 of 0.572
+PASS style.height is "50px"
+PASS style.webkitMaskPositionY is "15px"
+
+FullscreenButton
+PASS rgba(style.backgroundColor).r is 255
+PASS rgba(style.backgroundColor).g is 255
+PASS rgba(style.backgroundColor).b is 255
+PASS rgba(style.backgroundColor).a is within 0.001 of 0.572
+PASS style.height is "50px"
+PASS style.webkitMaskPositionY is "13px"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Comment 1 Ryan Haddad 2016-10-18 09:24:04 PDT
The test only seems to be flaky on mac-wk1.
Comment 2 Ryan Haddad 2016-10-18 13:40:12 PDT
Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/207485
Comment 3 Antoine Quint 2017-02-07 04:47:05 PST
Created attachment 300802 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-02-07 05:24:02 PST
Comment on attachment 300802 [details]
Patch for landing

Clearing flags on attachment: 300802

Committed r211804: <http://trac.webkit.org/changeset/211804>
Comment 5 WebKit Commit Bot 2017-02-07 05:24:05 PST
All reviewed patches have been landed.  Closing bug.