WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 163587
[EFL] Build break since
r207442
https://bugs.webkit.org/show_bug.cgi?id=163587
Summary
[EFL] Build break since r207442
Ryuan Choi
Reported
2016-10-17 23:35:33 PDT
In file included from ../../Source/WebCore/rendering/style/BorderValue.h:28:0, from ../../Source/WebCore/rendering/style/BorderData.h:28, from ../../Source/WebCore/rendering/RenderTheme.h:26, from ../../Source/WebCore/rendering/RenderThemeEfl.h:33, from ../../Source/WebCore/rendering/RenderThemeEfl.cpp:28: ../../Source/WebCore/platform/graphics/Color.h: In function ‘bool WebCore::fillColorsFromEdjeClass(Evas_Object*, const char*, WebCore::Color*, WebCore::Color*, WebCore::Color*)’: ../../Source/WebCore/platform/graphics/Color.h:386:13: error: ‘void WebCore::Color::setRGB(WebCore::RGBA32)’ is private inline void Color::setRGB(RGBA32 rgb) ^ ../../Source/WebCore/rendering/RenderThemeEfl.cpp:444:48: error: within this context color1->setRGB(makeRGBA(r1, g1, b1, a1)); ^ In file included from ../../Source/WebCore/rendering/style/BorderValue.h:28:0, from ../../Source/WebCore/rendering/style/BorderData.h:28, from ../../Source/WebCore/rendering/RenderTheme.h:26, from ../../Source/WebCore/rendering/RenderThemeEfl.h:33, from ../../Source/WebCore/rendering/RenderThemeEfl.cpp:28: ../../Source/WebCore/platform/graphics/Color.h:386:13: error: ‘void WebCore::Color::setRGB(WebCore::RGBA32)’ is private inline void Color::setRGB(RGBA32 rgb) ^ ../../Source/WebCore/rendering/RenderThemeEfl.cpp:446:48: error: within this context color2->setRGB(makeRGBA(r2, g2, b2, a2)); ^ In file included from ../../Source/WebCore/rendering/style/BorderValue.h:28:0, from ../../Source/WebCore/rendering/style/BorderData.h:28, from ../../Source/WebCore/rendering/RenderTheme.h:26, from ../../Source/WebCore/rendering/RenderThemeEfl.h:33, from ../../Source/WebCore/rendering/RenderThemeEfl.cpp:28: ../../Source/WebCore/platform/graphics/Color.h:386:13: error: ‘void WebCore::Color::setRGB(WebCore::RGBA32)’ is private inline void Color::setRGB(RGBA32 rgb) ^ ../../Source/WebCore/rendering/RenderThemeEfl.cpp:448:48: error: within this context color3->setRGB(makeRGBA(r3, g3, b3, a3)); ^ ninja: build stopped: subcommand failed.
Attachments
Patch
(1.45 KB, patch)
2016-10-17 23:39 PDT
,
Ryuan Choi
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryuan Choi
Comment 1
2016-10-17 23:39:12 PDT
Created
attachment 291923
[details]
Patch
WebKit Commit Bot
Comment 2
2016-10-18 00:14:00 PDT
Comment on
attachment 291923
[details]
Patch Clearing flags on attachment: 291923 Committed
r207455
: <
http://trac.webkit.org/changeset/207455
>
WebKit Commit Bot
Comment 3
2016-10-18 00:14:05 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug