Bug 163586 - [DOMJIT] Use NativeCallFrameTracer for operations used for DOMJIT slow calls
Summary: [DOMJIT] Use NativeCallFrameTracer for operations used for DOMJIT slow calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on: 163223
Blocks:
  Show dependency treegraph
 
Reported: 2016-10-17 23:24 PDT by Yusuke Suzuki
Modified: 2016-10-18 11:49 PDT (History)
8 users (show)

See Also:


Attachments
Patch (12.08 KB, patch)
2016-10-17 23:40 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (25.44 KB, patch)
2016-10-18 00:08 PDT, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-10-17 23:24:56 PDT
DOMJIT slow calls should use NativeCallFrameTracer as the same to the other operations.
Comment 1 Yusuke Suzuki 2016-10-17 23:40:10 PDT
Created attachment 291924 [details]
Patch
Comment 2 Yusuke Suzuki 2016-10-18 00:08:46 PDT
Created attachment 291927 [details]
Patch
Comment 3 Saam Barati 2016-10-18 01:02:04 PDT
Comment on attachment 291927 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2016-10-18 01:16:12 PDT
Committed r207456: <http://trac.webkit.org/changeset/207456>
Comment 5 Csaba Osztrogonác 2016-10-18 02:43:50 PDT
(In reply to comment #4)
> Committed r207456: <http://trac.webkit.org/changeset/207456>

It broke the Apple Mac cmake build: 

In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/domjit/JSNodeDOMJIT.cpp:36:
/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/ForwardingHeaders/interpreter/FrameTracers.h:28:10: fatal error: 'JavaScriptCore/FrameTracers.h' file not found
#include <JavaScriptCore/FrameTracers.h>
         ^
1 error generated.
Comment 6 Yusuke Suzuki 2016-10-18 11:49:39 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Committed r207456: <http://trac.webkit.org/changeset/207456>
> 
> It broke the Apple Mac cmake build: 
> 
> In file included from
> /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/domjit/
> JSNodeDOMJIT.cpp:36:
> /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/
> ForwardingHeaders/interpreter/FrameTracers.h:28:10: fatal error:
> 'JavaScriptCore/FrameTracers.h' file not found
> #include <JavaScriptCore/FrameTracers.h>
>          ^
> 1 error generated.

This is related to forwarding header clean up in CMake.
Rebuilding fixes the issue[1]. (JSNodeDOMJIT.cpp is compiled correctly)

[1]: https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/9293/steps/compile-webkit/logs/stdio