Bug 163584 – Provide better form validation messages

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Provide better form validation messages that match more closely the ones from Chrome and Firefox.

[Chris Dumez]

Created attachment 291916 [details]
Patch

[Build Bot]

Comment on attachment 291916 [details]
Patch

Attachment 291916 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2309806

New failing tests:
fast/forms/validation-message-appearance.html

[Build Bot]

Created attachment 291918 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 291919 [details]
Patch

[Build Bot]

Comment on attachment 291919 [details]
Patch

Attachment 291919 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2310301

New failing tests:
fast/forms/date/input-date-validation-message.html

[Build Bot]

Created attachment 291925 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Chris Dumez]

Created attachment 291966 [details]
Patch

[Darin Adler]

Comment on attachment 291966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291966&action=review

> Source/WebCore/platform/LocalizedStrings.cpp:1119
> +    return formatLocalizedString(WEB_UI_STRING("Value must be greater than or equal to %@.", "Validation message for input form controls with value lower than allowed minimum"), minimum.createCFString().get());

I think we eventually should come up with a cross platform way to do the substitution instead of relying on formatLocalizedString. Just a simple substitution rather than %@ would work.

> Source/WebCore/platform/LocalizedStrings.cpp:1129
> +    return formatLocalizedString(WEB_UI_STRING("Value must be less than or equal to %@.", "Validation message for input form controls with value higher than allowed maximum"), maximum.createCFString().get());

Ditto.

[WebKit Commit Bot]

Comment on attachment 291966 [details]
Patch

Clearing flags on attachment: 291966

Committed r207509: <http://trac.webkit.org/changeset/207509>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.