Bug 163580 – Update TrackEvent to stop using legacy [ConstructorTemplate=Event]

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Update TrackEvent to stop using legacy [ConstructorTemplate=Event] and use a regular constructor as in the specification:
- https://html.spec.whatwg.org/#the-trackevent-interface

[Chris Dumez]

Created attachment 291911 [details]
Patch

[Sam Weinig]

Comment on attachment 291911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291911&action=review

> Source/WebCore/html/track/TrackEvent.idl:30
> +    [CustomGetter] readonly attribute (VideoTrack or AudioTrack or TextTrack)? track;

It would be nice to work towards getting rid of this CustomGetter by storing the track as a variant, but let's come back to that later.

[WebKit Commit Bot]

Comment on attachment 291911 [details]
Patch

Clearing flags on attachment: 291911

Committed r207468: <http://trac.webkit.org/changeset/207468>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 291911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291911&action=review

>> Source/WebCore/html/track/TrackEvent.idl:30
>> +    [CustomGetter] readonly attribute (VideoTrack or AudioTrack or TextTrack)? track;
> 
> It would be nice to work towards getting rid of this CustomGetter by storing the track as a variant, but let's come back to that later.

All we’d need is a track() function that returns a variant. Don’t necessarily need to store it as a variant!

[Chris Dumez]

Comment on attachment 291911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291911&action=review

>>> Source/WebCore/html/track/TrackEvent.idl:30
>>> +    [CustomGetter] readonly attribute (VideoTrack or AudioTrack or TextTrack)? track;
>> 
>> It would be nice to work towards getting rid of this CustomGetter by storing the track as a variant, but let's come back to that later.
> 
> All we’d need is a track() function that returns a variant. Don’t necessarily need to store it as a variant!

We'd need a toJS() implementation that properly deals with std::variant as well.